ENG-1693 Add insert backlink checkbox to ModifyNodeModal

[trangdoan982]

https://www.loom.com/share/2c08071a85d849f0b13e828541a0a429

Summary

• Adds an Insert backlink checkbox at the bottom of ModifyNodeModal (create mode only)
• Smart defaults based on context — no new props needed:
  • true when the modal is opened with pre-filled text (user had text selected before invoking)
  • true when the user selects an existing node from the search
  • false when opened with no selected text (blank create)
  • User can always toggle the checkbox manually
• Gates backlink insertion in both the canvas flow (nodeCreationFlow.ts) and the editor command flow (registerCommands.ts) on the checkbox value

Test plan

• Open "Create discourse node" with no selected text → checkbox unchecked; submitting does not insert backlink
• Select text in editor, open via right-click or command → checkbox checked; submitting inserts backlink at cursor
• Open modal, pick an existing node from search → checkbox auto-checks; submitting inserts backlink
• Open modal, pick existing node, clear selection → checkbox resets to initial default
• User manually toggles checkbox in any case → submission respects the toggled value
• Canvas: Don't show Insert backlink

Closes ENG-1693

🤖 Generated with Claude Code

[linear-code]

ENG-1693

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[mdroidian]

Requesting changes because this introduces a bug in the canvas create-node flow.

Broader design concern

Separate from the immediate bug, I’m worried about ModifyNodeModal continuing to accumulate workflow-specific props and submit fields.

The modal is now responsible for:

• create mode
• edit mode
• existing-node search
• relationship creation
• editor insertion
• canvas creation behavior
• backlink insertion

That makes the function hard to track because the meaning of a submit field depends heavily on which caller opened the modal.

It also makes bugs hard to debug. insertBacklink is a good example: in an editor flow, it means “insert a wikilink into the editor.” In the canvas flow, it ended up controlling whether the shape gets the blockref it needs to resolve to a file. Those are very different side effects hidden behind the same boolean.

I’d prefer we make caller capabilities explicit instead of inferring them inside the modal from global workspace state, and avoid using one generic submit payload for unrelated workflows. But we can continue that exploration in ENG-1750: Refactor Obsidian ModifyNodeModal contract for clearer workflow ownership

[mdroidian]

I believe this breaks canvas.

https://www.loom.com/share/bdb2e4e379ee4d9a894e7a2072e77816

[graphite-app]

PR size/scope check

This PR is over our review-size guideline.

• Recommended: ~200 lines changed
• Acceptable limit: up to 400 lines when well-scoped/self-contained
• Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

• What single problem this PR solves
• Why the files/changes are coupled

[mdroidian]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ba4a87f7d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Hide backlink toggle when submit handler can't honor it

Rendering the checkbox whenever hasEditorContext is true exposes it in create flows whose onSubmit handlers do not consume insertBacklink (for example, the image-conversion and tag-node handlers), so users can uncheck Insert backlink and still get link replacement behavior. This makes the new control a no-op in those contexts and breaks the expectation that manual toggles are respected; gate this UI on caller support (or thread insertBacklink through all submit handlers).

Useful? React with 👍 / 👎.

[mdroidian]

Could you submit a video showing that the bug as been fixed?

Also, please take a look at #1018 (comment)