Avoid redraw call when resized to zero size#449
Open
Klemen2 wants to merge 1 commit into
Open
Conversation
with_viewport already calls request_redraw with a safety check this should also fix occasional crash when minimizing the window
Member
|
Hmm... I'm not against removing duplicate calls to |
Klemen2
changed the title
Contributor
Author
|
0.31 does indeed deduplicate automatically. I've changed the title to better describe the change, that occasional crash could have been a driver issue since it used to crash when using use_window().set_minimized(true) and after updating it this doesn't happen on main without changing anything else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with_viewport already calls request_redraw with a safety check
this should also fix occasional crash when minimizing the window