Skip to content

fix(api): Make sure our error type is Sync for compatibility with anyhow #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dinnerbone merged 1 commit into from
May 17, 2026
+5 −5
Merged

fix(api): Make sure our error type is Sync for compatibility with anyhow #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/rascal/src/sources.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use crate::SourceProvider;
use crate::internal::span::FileId;
use std::fmt::Debug;
use std::rc::Rc;
use std::sync::Arc;

#[derive(Debug, Default)]
pub(crate) struct SourceSet {
sources: Vec<Rc<SourceFile>>,
sources: Vec<Arc<SourceFile>>,
}

impl SourceSet {
Expand All @@ -17,14 +17,14 @@ impl SourceSet {
&mut self,
path: String,
provider: &P,
) -> Result<Rc<SourceFile>, std::io::Error> {
) -> Result<Arc<SourceFile>, std::io::Error> {
if let Some(id) = self.sources.iter().position(|source| source.path == path) {
return Ok(self.sources[id].clone());
}

let source = provider.load(&path)?;
let file_id = FileId::new(self.sources.len());
let source_file = Rc::new(SourceFile {
let source_file = Arc::new(SourceFile {
path,
file_id,
source,
Expand All @@ -33,7 +33,7 @@ impl SourceSet {
Ok(source_file)
}

pub fn get_source(&self, file_id: FileId) -> Option<&Rc<SourceFile>> {
pub fn get_source(&self, file_id: FileId) -> Option<&Arc<SourceFile>> {
self.sources.get(file_id.0)
}
}
Expand Down