Skip to content

Fix Inline Constants Cross-Signature Commit Inconsistency for vulkan impl #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hzqst wants to merge 2 commits into from
Closed

Fix Inline Constants Cross-Signature Commit Inconsistency for vulkan impl #755

hzqst wants to merge 2 commits into from

Conversation

@hzqst
Copy link
Contributor

@hzqst hzqst commented Jan 12, 2026

@hzqst hzqst marked this pull request as ready for review January 12, 2026 02:54
@TheMostDiligent
Copy link
Contributor

TheMostDiligent commented Jan 12, 2026

We need a unit test for this. Every bug/issue/new feature should be covered.
I think it can be reproduced this way:

  • Create two compatible signatures
  • Use signature 1 to create PSO
  • Use signature 2 to create SRB

@hzqst hzqst closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheMostDiligent TheMostDiligent Awaiting requested review from TheMostDiligent TheMostDiligent is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hzqst @TheMostDiligent