-
Notifications
You must be signed in to change notification settings - Fork 6
Better job tracking and events for the dashboard #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pabs3
wants to merge
19
commits into
DigitalDwagon:master
Choose a base branch
from
pabs3:better-job-tracking-and-events
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pabs3
commented
Jan 29, 2026
- Remove unnecessary whitespace
- Drop jobCards const since it is unused
- Drop duplicate updates of startTime/status
- Add trailing line ending characters
- Change terminology from active jobs to running jobs
- Change terminology from success/ended jobs to completed jobs
- Change terminology for running/queued length from jobs to count
- Enable automatic pings on the WebSockets
- Split border CSS param into border-width border-style border-color params
- Add job running event
- Add aborted events for queued but not started jobs
- Send log messages for all job events
- Only get the list of running jobs once for slightly more efficiency
- Improve the job cards
- add status class to the job container
- add id to the job container
- make username optional
- show platform in user title if present
- prevent log scrolling from hiding job explanation
- add each item one at a time
- Add job queue to the dashboard interface
- Improve dashboard JavaScript based job tracking
- Reconnect the WebSockets when they close/fail.
- Update the queue/job counts as job events come in.
- Move started jobs out of the queue.
- Remove the /cards/ API since it adds latency.
- Track all of the event types properly.
- Handle logs for not yet known jobs properly.
- Add indicators of the different job status types.
- Only reload the page when JavaScript is disabled.
- Detect use of template as a browser override.
- Add a button to clear and reload jobs.
For compatibility with editors that always add trailing line ending chars.
For consistency with the COMPLETED value of the JobStatus enum.
More easily understandable at first glance.
Avoids the dashboard client getting disconnected quickly, and reduces the need for clients to reload the page and or reconnect the WebSockets quite as often.
…rams Makes it easier to change the border CSS parameters independently.
Makes it more obvious in the log what the status is.
- add status class to the job container - add id to the job container - make username optional - show platform in user title if present - prevent log scrolling from hiding job explanation - add each item one at a time
- Reconnect the WebSockets when they close/fail. - Update the queue/job counts as job events come in. - Move started jobs out of the queue. - Remove the /cards/ API since it adds latency. - Track all of the event types properly. - Handle logs for not yet known jobs properly. - Add indicators of the different job status types. - Only reload the page when JavaScript is disabled. - Detect use of template as a browser override. - Add a button to clear and reload jobs.
- JobMeta#getUserName and JobMeta#getPlatform aren't Optional - when posting JobRunningEvent, the job variable doesn't exist, use "this" to refer to the current object - missing ; - call to deleted cards method was not deleted
allows you to get the full job details (like /api/jobs/JOBID) for all jobs at once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.