Skip to content

Use Path.Combine instead of string concatenation #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincent1405 wants to merge 4 commits into
base: develop
Choose a base branch
from
+3 −3
Open

Use Path.Combine instead of string concatenation #1112

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a23e07
Update SoapEndpointMiddleware.cs
vincent1405 Jan 20, 2025
1fd2227
Update SoapEndpointMiddleware.cs
vincent1405 Jan 20, 2025
00d0c58
Update src/SoapCore/SoapEndpointMiddleware.cs
andersjonsson Feb 20, 2025
a858cee
Merge branch 'DigDes:develop' into patch-1
vincent1405 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/SoapCore/SoapEndpointMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,14 +1124,14 @@ private async Task ProcessMetaFromFile(HttpContext httpContext, bool showDocumen
meta.CurrentWebService = mapping.UrlOverride;
}

meta.WSDLFolder = mapping.WSDLFolder;
meta.WSDLFolder = mapping.WSDLFolder ?? "";
meta.XsdFolder = mapping.SchemaFolder;
meta.ServerUrl = GetServerUrl(options, httpContext);

string wsdlfile = mapping.WsdlFile;

string path = options.AppPath;
string wsdl = await meta.ReadLocalFileAsync(path + Path.AltDirectorySeparatorChar + meta.WSDLFolder + Path.AltDirectorySeparatorChar + wsdlfile);
string path = options.AppPath ? "";
Comment thread
andersjonsson marked this conversation as resolved.
Outdated
string wsdl = await meta.ReadLocalFileAsync(Path.Combine(path, meta.WSDLFolder, wsdlfile));
string modifiedWsdl = meta.ModifyWSDLAddRightSchemaPath(wsdl);

if (showDocumentation)
Expand Down