-
Notifications
You must be signed in to change notification settings - Fork 1
Added logic to support recursive searching of upstream visits #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 46.01% 46.04% +0.03%
==========================================
Files 91 91
Lines 9625 9636 +11
Branches 1256 1260 +4
==========================================
+ Hits 4429 4437 +8
- Misses 4977 4978 +1
- Partials 219 221 +2 🚀 New features to boost your workflow:
|
…t recursively, and return it instead of using a variable from outside the function scope
Ensure that dcg, dc and pjid exist before inserting into murfey db. Add a sleep for the case where they cannot be registered to allow the database to settle.
stephen-riggs
approved these changes
Jan 14, 2026
Contributor
stephen-riggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better now the function has everything in scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic for
find_upstream_visitslooks only in the folder specified. This is a problem as it means that, in the event the data is saved by year, the machine config will have to be updated with the new year, and access to the old year's data will be lost.To circumvent this, we implement recursive searching logic, such that Murfey will recursively search through the specified number of layers in the stated data directory to find matches for the current visit. This solution allows for the current
upstream_data_directorieskey format to be kept as-is, while future-proofing the code as the years go by, allowing past visits to continue to be exposed until they are deleted from the system.