Skip to content

Conversation

@tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jan 12, 2026

The current logic for find_upstream_visits looks only in the folder specified. This is a problem as it means that, in the event the data is saved by year, the machine config will have to be updated with the new year, and access to the old year's data will be lost.

To circumvent this, we implement recursive searching logic, such that Murfey will recursively search through the specified number of layers in the stated data directory to find matches for the current visit. This solution allows for the current upstream_data_directories key format to be kept as-is, while future-proofing the code as the years go by, allowing past visits to continue to be exposed until they are deleted from the system.

@tieneupin tieneupin self-assigned this Jan 12, 2026
@tieneupin tieneupin added the enhancement New feature or request label Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.04%. Comparing base (6f96b62) to head (f8ebe2a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   46.01%   46.04%   +0.03%     
==========================================
  Files          91       91              
  Lines        9625     9636      +11     
  Branches     1256     1260       +4     
==========================================
+ Hits         4429     4437       +8     
- Misses       4977     4978       +1     
- Partials      219      221       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…t recursively, and return it instead of using a variable from outside the function scope
tieneupin and others added 2 commits January 13, 2026 09:53
Ensure that dcg, dc and pjid exist before inserting into murfey db. Add a sleep for the case where they cannot be registered to allow the database to settle.
Copy link
Contributor

@stephen-riggs stephen-riggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now the function has everything in scope

@tieneupin tieneupin merged commit ed26545 into main Jan 14, 2026
17 checks passed
@tieneupin tieneupin deleted the recursive-upstream-visit-search branch January 14, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants