Skip to content

Conversation

@stephen-riggs
Copy link
Contributor

  • The recursive machine config update did not work for dictionaries as this caused in-place modification of the memory location of the general config
  • The destination selection needs to not run with string None

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.99%. Comparing base (58b66ba) to head (01fbb12).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   43.98%   43.99%           
=======================================
  Files          93       93           
  Lines       10189    10190    +1     
  Branches     1320     1320           
=======================================
+ Hits         4482     4483    +1     
  Misses       5486     5486           
  Partials      221      221           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for fixing it and for writing some tests to address it.

MyPy revealed some typing-related errors in murfey.client.analyser and murfey.client.contexts.spa that I've tried to handle as well. Could you let me know if those changes are alright?

@stephen-riggs
Copy link
Contributor Author

Looks good to me! Thanks for fixing it and for writing some tests to address it.

MyPy revealed some typing-related errors in murfey.client.analyser and murfey.client.contexts.spa that I've tried to handle as well. Could you let me know if those changes are alright?

Yes, the typing looks fine

@stephen-riggs stephen-riggs merged commit 57b110d into main Jan 12, 2026
17 checks passed
@stephen-riggs stephen-riggs deleted the v23-fixes branch January 12, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants