Code review fixes#3
Merged
Merged
Conversation
- version-switcher.mjs: satisfy biome (template literal in withTrailingSlash, optional chain in directive run); make the pydata `preferred` entry render a star marker instead of a dead no-op ternary - test-url-logic.mjs: cover entryLabel (the gap that hid the dead code) - docs/index.md + CLAUDE.md: the switcher action's `output` is required, not defaulted — pass it explicitly in the consuming examples - biome.json: respect .gitignore (skip docs/_build) and pin tab/double-quote formatter defaults; reformat package.json + devcontainer.json to match Also includes the in-flight biome reformatting of the source/test files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- make-switcher.mjs: compute the preferred (newest deployed non-prerelease tag, else main/master) version, flag it preferred:true in switcher.json, and write a root index.html redirecting to it. Action takes an output-dir and always writes both files; prerelease test mirrors _release.yml - delete committed .github/pages/index.html — the redirect is now generated each deploy (first deploy with no tags still points at main) - _docs.yml: fix `cp` into a missing parent (mkdir -p), consolidate the two build copies into one Stage step, rename _staging -> pages - docs + CLAUDE.md: output-dir input, two-file output, redirect/preferred behaviour - tests: cover isPrerelease, preferredVersion, the preferred flag, and the redirect Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
coretl
added a commit
that referenced
this pull request
Jun 19, 2026
origin/main was 24cc141, a merge of an early code-review-fixes (714be09) whose old layout (switcher/, make-switcher.mjs, nested plugin) this redesign replaced. Both its parents are already in our history, so keep our tree wholesale (-s ours) and retain the commit in history; the push is now a fast-forward, no force.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.