Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
=======================================
Coverage 92.87% 92.88%
=======================================
Files 155 155
Lines 8494 8502 +8
=======================================
+ Hits 7889 7897 +8
Misses 605 605
🚀 New features to boost your workflow:
|
noemifrisina
requested changes
Mar 3, 2026
Contributor
noemifrisina
left a comment
noemifrisina
left a comment
There was a problem hiding this comment.
Thanks, a couple of things to do...
I think we may need to run this on the beamline to be totally sure it does the same as the old one
adaudon
force-pushed
the
ui86-move_on_click
branch
5 times, most recently
from
069450e to
83199cc
Compare
adaudon
force-pushed
the
ui86-move_on_click
branch
from
9074afc to
80c0b04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/mx-daq-ui#86
Instructions to reviewer on how to test:
Checks for reviewer