Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1622 +/- ##
==========================================
+ Coverage 92.92% 92.94% +0.01%
==========================================
Files 157 157
Lines 8566 8584 +18
==========================================
+ Hits 7960 7978 +18
Misses 606 606
🚀 New features to boost your workflow:
|
DominicOram
requested changes
Feb 17, 2026
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, I've added a few comments
* Use protocols instead of smargon type for FGS composite * Rename devices to gonio in all plans * Include generic type everywhere in plan
adaudon
force-pushed
the
1601-Countdown
branch
from
49bafe9 to
6ef9b5d
Compare
DominicOram
requested changes
Mar 6, 2026
Contributor
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, a couple more comments but mostly looks good
| with caplog.at_level("INFO"): | ||
| run_udc_when_requested(bluesky_context, udc_runner) | ||
|
|
||
| assert "Synchrotron machine countdown too low" in caplog.text |
Contributor
There was a problem hiding this comment.
Could: It would be good to test here that no collections are run in this case, you can do this by asserting that mock_load_centre_collect hasn't been called
adaudon
force-pushed
the
1601-Countdown
branch
3 times, most recently
from
3fc6cb1 to
07dee25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1601
Requires DiamondLightSource/dodal#1922
Instructions to reviewer on how to test:
Checks for reviewer