Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 98.48% 97.00% -1.48%
==========================================
Files 14 17 +3
Lines 725 769 +44
==========================================
+ Hits 714 746 +32
- Misses 11 23 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DominicOram
requested changes
Jun 12, 2026
DominicOram
left a comment
DominicOram
left a comment
Contributor
There was a problem hiding this comment.
Thanks, some comments in code
| @@ -0,0 +1,2 @@ | |||
| def test_get_valid_access_token(): | |||
| from daq_queuing_service.log import LOGGER | ||
|
|
||
|
|
||
| class UDCTokenRetriever: |
Contributor
There was a problem hiding this comment.
Should: I think it would be good to have some unit tests on this
| from daq_queuing_service.blueapi_interaction.token_retriever import UDCTokenRetriever | ||
|
|
||
|
|
||
| def get_blueapi_clients( |
Contributor
There was a problem hiding this comment.
Should: I think it would be good to have some unit tests on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.