Skip to content

fix: Check plan outcome when calling Plan objects#1470

Draft
tpoliaw wants to merge 1 commit intomainfrom
client-task-result
Draft

fix: Check plan outcome when calling Plan objects#1470
tpoliaw wants to merge 1 commit intomainfrom
client-task-result

Conversation

@tpoliaw
Copy link
Copy Markdown
Contributor

@tpoliaw tpoliaw commented Apr 2, 2026

When using the client.plans.plan_name() approach to running plans, the
task status returned by the server was not being checked so that plans
failing did not raise exceptions on the client side.

Checking the task status also allows values returned by plans to be
accessed easily if they were serializable.

When using the client.plans.plan_name() approach to running plans, the
task status returned by the server was not being checked so that plans
failing did not raise exceptions on the client side.

Checking the task status also allows values returned by plans to be
accessed easily if they were serializable.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.08%. Comparing base (57ed429) to head (654e59b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/blueapi/client/client.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1470      +/-   ##
==========================================
- Coverage   95.20%   95.08%   -0.12%     
==========================================
  Files          43       43              
  Lines        3128     3136       +8     
==========================================
+ Hits         2978     2982       +4     
- Misses        150      154       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BlueapiClient reports successful response on device move when actually fails

1 participant