Template extra config#35
Open
JamesDoingStuff wants to merge 1 commit intoDiamondLightSource:i15-try-loginfrom
Open
Template extra config#35JamesDoingStuff wants to merge 1 commit intoDiamondLightSource:i15-try-loginfrom
JamesDoingStuff wants to merge 1 commit intoDiamondLightSource:i15-try-loginfrom
Conversation
apps/i15-1/helm/values.yaml
Outdated
| uri: http://i15-1-blueapi.diamond.ac.uk | ||
|
|
||
| oauth2-proxy: | ||
| extraConfig: | |
Collaborator
There was a problem hiding this comment.
Don't know how best to handle this going forward (it may be that this should be the default config anyway). I would suggest renaming this prop for now, as this makes it seem like oauth2-proxy.extraConfig is a standard prop in the oauth2-proxy chart which you'd access via ui-base.
JamesDoingStuff
force-pushed
the
i15-try-login
branch
from
cd6fcb9 to
eec5402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.B. This isn't targeting main
A suggestion for changes required in #29 - I haven't tested this! (don't have access to cluster)
@noemifrisina @douglaswinter