LIMS-2141: Suppress errors if visit directory has been replaced with a file#1051
Open
LIMS-2141: Suppress errors if visit directory has been replaced with a file#1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2141
Summary:
If the whole visit folder (or any folder in the path of an expected file) has been replaced with a file, then the combination of
file_existsandopen_basedircause an error. See eg https://ispyb.diamond.ac.uk/dc/visit/cm40636-1Changes:
To test:
Alternatives:
The other option would be to manually check all paths for directories replaced by files, eg
But that seemed to be slower by a factor of 5-10x, and could result in a lot of extra calls to the metadata server.