Skip to content

LIMS-2125: Allow use of shipping service for EU dispatches#1049

Open
ndg63276 wants to merge 3 commits intomasterfrom
improvement/LIMS-2125/allow-use-of-shipping-service-for-eu-dispatches
Open

LIMS-2125: Allow use of shipping service for EU dispatches#1049
ndg63276 wants to merge 3 commits intomasterfrom
improvement/LIMS-2125/allow-use-of-shipping-service-for-eu-dispatches

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-2125

Summary:

The next step in migration to the shipping service is for users from EU (and some other) countries to use it, for outgoing (dispatch) shipments. This will be behind a feature flag, and should probably not be enabled until ULIMS-1186 is completed.

Changes:

  • Add new boolean feature flag use_shipping_service_nde
  • Update the callback function for shipping service confirmations to cope with pending requests, booked requests and cancellations
  • Only email users / goods handling after the shipment is booked, not when requested
  • Tidy up some repeated code into functions
  • Allow dots in country names as some countries in our list have dots in (eg Dominican Rep.)

To test:

  • Currently deployed on ispyb-test for easier testing
  • Go to any proposal (eg mx23694), edit a lab contact to be in France. Make a shipment with that lab contact.
  • Don't worry about booking the incoming shipment, just click "Dispatch" next to the dewar
  • On the next page, make sure the country still says France, and click "Use Facility Account". Check the firm shrinks to the minimal version.
  • Change the country to somewhere outside Europe, check the form expands again. Set it back to France.
  • Click Proceed and check you are taken to the shipping service test server.
  • Change your country to France, use a valid French post code (eg 12345) and a valid French EORI number (eg FR123456789)
  • Click Next then Submit, check it says a member of staff will book the shipment.
  • Click Done and check you are taken back to your shipment in Synchweb. If ULIMS-1186 is done, you should see a status of "dispatch-requested".
  • Check the Dispatch button has now become "View Dispatch Request", which takes you back to the shipping service.
  • James or Mark should have an email asking them to book the shipment, get them to put in a tracking number. Check the dewar status becomes "dispatch-booked" and the tracking number appears in Synchweb.
  • Click through to the shipping service again, and click to Cancel to shipment. Check Synchweb now says "Dispatch request cancelled"

@ndg63276 ndg63276 requested review from MattPrit and gfrn March 16, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant