Skip to content

chore(agents): add reusable review skills - #1922

Merged
Benoît Cortier (CBenoit) merged 4 commits into
masterfrom
cbenoit-port-review-skills
Aug 9, 2026
Merged

chore(agents): add reusable review skills#1922
Benoît Cortier (CBenoit) merged 4 commits into
masterfrom
cbenoit-port-review-skills

Conversation

@CBenoit

Copy link
Copy Markdown
Member

Port reusable compression, documentation, prose, and attribution skills for Gateway agents.

Add a contract-aware review orchestrator that routes only applicable changes through authoritative contract checks.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

Port reusable compression, documentation, prose, and attribution skills for Gateway agents.

Add a contract-aware review orchestrator that routes only applicable changes through authoritative contract checks.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 9, 2026 18:10
@CBenoit

Benoît Cortier (CBenoit) commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Implementation notes:

  • Ported code-compressor, docs-compressor, docs-writer, markdown-writer, prose-verifier, and prose-writer without behavioral changes.
  • Generalized skeptical-reviewer by removing repository-specific naming and accepting findings from any review pass instead of only protocol or contract analysis.
  • Refined llm-comment-footer to say "content" instead of "reply" so the same attribution accurately covers issue bodies and comments; its attribution scope is unchanged.
  • Replaced the RDP-specific protocol-reviewer with external-contract-reviewer so contract checks apply only to relevant HTTP/OpenAPI, WebSocket, relay/tunneling, configuration-schema, and agent/platform changes.
  • Adapted code-review to route applicable diffs through the external-contract reviewer, always run code compression and skeptical review, and add documentation/prose passes when relevant.
  • No sync manifest was added because this repository has no local skills-sync.yml; the skills use its auto-discovered .agents/skills and .github/skills locations.
  • All ten skills pass the repository Tessl lint helper. The final diff also passes whitespace and IronRDP-specific reference checks.

Note

Human-tuned, LLM-assisted content.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds reusable agent-review skills and a contract-aware review orchestrator.

Changes:

  • Adds focused code, documentation, prose, contract, and skeptical review passes.
  • Adds writing guidance and LLM attribution rules.
  • Coordinates parallel review passes with final evidence normalization.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/skills/code-review/SKILL.md Orchestrates specialized review passes.
.agents/skills/skeptical-reviewer/SKILL.md Adds evidence-driven final review.
.agents/skills/prose-writer/SKILL.md Defines concise prose guidance.
.agents/skills/prose-verifier/SKILL.md Reviews edited prose.
.agents/skills/markdown-writer/SKILL.md Defines Markdown-writing conventions.
.agents/skills/llm-comment-footer/SKILL.md Defines LLM attribution footers.
.agents/skills/external-contract-reviewer/SKILL.md Reviews external contract compliance.
.agents/skills/docs-writer/SKILL.md Defines technical documentation guidance.
.agents/skills/docs-compressor/SKILL.md Reviews documentation concision.
.agents/skills/code-compressor/SKILL.md Reviews code simplification opportunities.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .agents/skills/external-contract-reviewer/SKILL.md Outdated
Remove repository-specific wording and make review handoff language generic across review pipelines.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Use content instead of reply so required footers accurately cover both issue bodies and comments.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Fall back to the governing specification when windows-protocols is unavailable in a repository-only agent environment.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit) added a commit to Devolutions/IronRDP that referenced this pull request Aug 9, 2026
Mirror all nine common agent skills from Devolutions Gateway.

Gateway is their canonical source. IronRDP-only skills remain local.

Synchronization depends on Gateway PR #1922 landing first:
Devolutions/devolutions-gateway#1922

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Benoît Cortier (CBenoit) merged commit e8912d3 into master Aug 9, 2026
42 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the cbenoit-port-review-skills branch August 9, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants