You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split out of #1831 (draft tracker — the TODO(agent-tunnel) marker is placed at the exact code site; not fixed yet).
Custom installer dialog labels show raw localization keys
Symptom: The Agent Tunnel dialog (and the base dialog title) render literal keys — AgentTunnelDlgTitle, AgentTunnelDlgEnrollmentStringLabel, AgentDlg_Title, … — instead of the translated text.
Root cause: The strings exist correctly in Strings_*.json and DevolutionsAgent_*.wxl. At runtime Project_UIInitialized loads the embedded .wxl into a local dict that only feeds the pre-flight MessageBoxes. The custom dialogs resolve [Key] via MsiRuntime.Localize, which is not populated from these custom strings — light.exe only emits strings referenced via !(loc.X) into the MSI, and the custom [Key] labels are never !(loc.X)-referenced (verified via dark.exe: the strings are absent from the built MSI's localization tables). Standard dialogs (Welcome/InstallDir) work only because WixSharp's built-in UI references those standard IDs via !(loc.X).
Suggested fix: wire the loaded strings dict into the ManagedUI runtime localization (or back the custom dialogs with a shared I18n that reads it). TODO(agent-tunnel) marker in Program.cs.
Let maintainers know that an action is required on their side
Add the label
release-requiredPlease cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)
when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)
Add the label
release-blockerFollow-up is required before cutting a new release
if a follow-up is required before cutting a new release
Add the label
publish-requiredPlease publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc)
when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)
Add the label
publish-blockerFollow-up is required before publishing libraries
if a follow-up is required before publishing libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1831 (draft tracker — the
TODO(agent-tunnel)marker is placed at the exact code site; not fixed yet).Custom installer dialog labels show raw localization keys
Symptom: The Agent Tunnel dialog (and the base dialog title) render literal keys —
AgentTunnelDlgTitle,AgentTunnelDlgEnrollmentStringLabel,AgentDlg_Title, … — instead of the translated text.Root cause: The strings exist correctly in
Strings_*.jsonandDevolutionsAgent_*.wxl. At runtimeProject_UIInitializedloads the embedded.wxlinto a local dict that only feeds the pre-flight MessageBoxes. The custom dialogs resolve[Key]viaMsiRuntime.Localize, which is not populated from these custom strings —light.exeonly emits strings referenced via!(loc.X)into the MSI, and the custom[Key]labels are never!(loc.X)-referenced (verified viadark.exe: the strings are absent from the built MSI's localization tables). Standard dialogs (Welcome/InstallDir) work only because WixSharp's built-in UI references those standard IDs via!(loc.X).Suggested fix: wire the loaded
stringsdict into the ManagedUI runtime localization (or back the custom dialogs with a sharedI18nthat reads it).TODO(agent-tunnel)marker inProgram.cs.