test(jetsocat): stabilize jmux proxy cli tests#1723
Merged
Benoît Cortier (CBenoit) merged 1 commit intomasterfrom Mar 19, 2026
Merged
test(jetsocat): stabilize jmux proxy cli tests#1723Benoît Cortier (CBenoit) merged 1 commit intomasterfrom
Benoît Cortier (CBenoit) merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes the jmux_proxy_write_hello_world integration test in the jetsocat CLI tests by removing timing- and platform-dependent listener startup assumptions (notably on Windows) while preserving the intended behavior.
Changes:
- Convert
jmux_proxy_write_hello_worldto an async#[tokio::test]and switch subprocess spawning tojetsocat_tokio_cmd. - Replace fixed sleeps with explicit readiness checks via
wait_for_port_boundfor all listeners involved. - Close the read server’s stdin and disable proxy auto-detection on the final client invocation (
--no-proxy).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Make the async JMUX wait for listener readiness explicitly and use the tokio command variant consistently.
Benoît Cortier (CBenoit)
force-pushed
the
test/fix-jetsocat-flaky-test
branch
from
65a40ec to
598ed3b
Compare
Benoît Cortier (CBenoit)
changed the title
Marc-André Moreau (mamoreau-devolutions)
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the async JMUX wait for listener readiness explicitly and use the tokio command variant consistently.