feat(jetsocat): add SAN and EKU diagnostics to doctor module#1719
Merged
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom Mar 19, 2026
Merged
feat(jetsocat): add SAN and EKU diagnostics to doctor module#1719Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
Benoît Cortier (CBenoit) merged 3 commits intomasterfrom
Conversation
Add certificate extension checks mirroring the gateway's TlsVerifyStrict validation. Each TLS backend (rustls, openssl, schannel) now runs two new diagnostics on the end-entity certificate: - check_san_extension: verifies the Subject Alternative Name extension is present - check_server_auth_eku: verifies the Extended Key Usage includes serverAuth Issue: DGW-350
Set end_entity_info in schannel_read_chain for the leaf certificate, so that cert checks work when loading a chain from a PEM file. Remove ChainCtx struct in favor of separate store and end_entity_info locals, using the same Option-unwrap pattern already established for the store. This naturally gates cert checks on chain availability and makes schannel_read_chain fail explicitly when the chain file contains no certificates. Remove the #[cfg_attr(windows, ignore)] attributes from doctor tests.
Adds a doctor test using a self-signed certificate that has no Subject Alternative Name extension and no Extended Key Usage extension. Verifies that the SAN and EKU checks fail with TlsVerifyStrict warnings on all backends, while unrelated checks still succeed.
Richard Markiewicz (thenextman)
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add certificate extension checks mirroring the gateway's TlsVerifyStrict
validation. Each TLS backend (rustls, openssl, schannel) now runs two new
diagnostics on the end-entity certificate:
Issue: DGW-350
Other commits:
I will rebase-merge.