Reduce Windows publish payload#4981
Open
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Open
Reduce Windows publish payload#4981Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Marc-André Moreau (mamoreau-devolutions) wants to merge 1 commit into
Conversation
Condition platform-specific Devolutions Avalonia theme packages so Windows builds no longer restore the macOS/Linux themes and their transitive controls dependency. Replace the small app-side Rx subscription usage with a local observer helper to avoid importing System.Reactive on Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Devolutions.AvaloniaControlsand its transitiveSystem.Reactivedependency, which selected a WindowsDesktop asset and pulled WPF/WinForms runtime files into the self-contained publish.SubscribeValuehelper for the app's Avalonia observable callbacks so Windows no longer depends onSystem.ReactiveforSubscribe(Action<T>)extension methods.PublishReadyToRunenabled.Impact
Windows
win-x64Release publish no longer contains the WPF/WinForms marker payload (PresentationFramework.dll,PresentationCore.dll,System.Windows.Forms*.dll,WindowsBase.dll,System.Xaml.dll,ReachFramework.dll,wpfgfx_cor3.dll).Measured against the original baseline:
Validation
dotnet publish src\UniGetUI.Avalonia\UniGetUI.Avalonia.csproj /noLogo /p:Configuration=Release /p:Platform=x64 -p:RuntimeIdentifier=win-x64 -v m /m:1dotnet test src\UniGetUI.Windows.slnx --verbosity q --nologo /p:Platform=x64 /m:1