Update WinGet manager for pinget 0.4#4762
Merged
Merged
Conversation
Marc-André Moreau (mamoreau-devolutions)
approved these changes
May 13, 2026
5062e00
into
main
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates UniGetUI to support the breaking changes in Pinget CLI 0.4.x, ensuring compatibility and robust behavior when using either the system WinGet CLI or the bundled Pinget CLI. The changes include updating dependencies, adapting JSON handling for new key formats, removing or modifying unsupported command-line flags, and adding comprehensive tests to verify correct argument generation for both CLI tools.
Dependency and Compatibility Updates:
Devolutions.Pinget.Cli.RustandDevolutions.Pinget.Corepackage references to version 0.4.2 to ensure compatibility with the latest Pinget CLI.Pinget CLI 0.4.x Support and Argument Handling:
--accept-source-agreementsand--disable-interactivityflags, and adjusted logic to only use flags that are valid for the selected CLI tool and operation.source list --output jsontosource export --output jsonas JSON output is no longer supported for the former in Pinget 0.4.1+.JSON Serialization and Deserialization:
JsonNamingPolicy.SnakeCaseLowerto match Pinget 0.4.x's snake_case JSON keys, and updated test data accordingly.Process Handling Improvements:
Testing and Validation:
These changes collectively ensure that UniGetUI remains compatible with both CLI tools and robust against future changes in Pinget or WinGet behavior.