fix(shell): centralize compact navigation overflow

[ucguy4u]

Summary

This PR introduces changes to shell navigation behavior.
Goal: centralize compact-phone destination overflow so root navigation density stays consistent and feature routes do not fork their own affordances.

Core outcome:

• adds one shared compact navigation policy with a four-tab phone budget
• routes lower-frequency destinations through a central More overflow entry on narrow screens

Changes

Code

• Added:
  • shared compact navigation policy and overflow layout config in navigation_provider.dart
  • widget coverage for overflow rendering and selection in app_shell_navigation_policy_test.dart
• Updated:
  • app_shell.dart to render direct destinations plus a shared overflow entry on compact widths
  • provider tests for compact vs wide navigation behavior
  • mobile UI standards with the default compact policy

Logic

• phones under the shared compact breakpoint keep Coins, Mind, Beats, and Stream visible
• Arena and Quest move behind one shared More destination on compact layouts
• larger layouts continue to render the full primary destination set from the same shared source of truth

API Changes (if any)

• None.

Database Changes (if any)

• None.

Observability / Logging

• None.

Performance Impact

• Latency: no meaningful change expected
• Throughput: no meaningful change expected
• Memory/CPU: negligible UI-only impact

Risks

• compact navigation now relies on the overflow sheet for Arena and Quest
• future root destinations must be added through the shared policy or the budget can drift
• Rollback plan:
  • revert this PR to restore six persistent bottom-nav destinations on phones

Testing

• Unit tests:
  • flutter analyze lib/core/providers/navigation_provider.dart lib/core/app/app_shell.dart test/core/providers/navigation_provider_test.dart test/core/app/app_shell_navigation_policy_test.dart
• Integration tests:
  • none
• Manual testing:
  • not run

Deployment Notes

• Config changes:
  • none
• Order of deployment:
  • normal app deployment

Related Commits

• fix(shell): centralize compact navigation overflow

Notes

• Closes [AGENT] UIUX-007: Centralize navigation overflow and hamburger policy #418

[github-actions]

Plugin Module Size Gate

Policy: modules over 3 MB must be delivered as plugins; plugin modules over 5 MB must document cache management.

Module	Size	Type	Status
No changed Dart/Flutter modules detected	n/a	n/a	OK

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🚀 PR Quick Check Summary

Check	Status	Description
PR Validation	✅ success	Title format, docs, bundled model guardrail
Code Quality	❌ failure	Analyze, formatting
Core Tests	✅ success	Core package unit tests

💡 Note: Full app tests, coverage reports, and security scans run on merge to main.

View Details