fix(shell): prevent duplicate route headers

[ucguy4u]

Summary

This PR introduces changes to shell and route header ownership.
Goal: ensure shell-mounted routes show only one visible top header.

Core outcome:

• shell-managed routes keep the shared AppShell chrome
• custom-header and nested flows hide the shell app bar instead of rendering duplicates
• provider and router tests lock the ownership behavior

Changes

Code

• Added:
  • app/test/core/app/app_shell_header_ownership_test.dart router-level shell/header coverage
• Updated:
  • app/lib/core/providers/navigation_provider.dart with route-to-header ownership rules
  • app/lib/core/app/app_shell.dart to gate shell chrome by current route
  • app/lib/core/routing/app_router.dart to pass the active path into the shell
  • app/test/core/providers/navigation_provider_test.dart with shell-vs-route ownership assertions

Logic

• /money, /mind, /mind/chat, /mind/models, and /games remain shell-owned
• custom-header routes like /music, /iptv, /quest, /mind/profile, and nested money flows become route-owned
• fullscreen behavior remains unchanged and still bypasses shell chrome entirely

API Changes (if any)

• None.

Database Changes (if any)

• None.

Observability / Logging

• None.

Performance Impact

• Latency: no meaningful change
• Throughput: no meaningful change
• Memory/CPU: negligible

Risks

• route ownership depends on path classification, so new shell routes must join the config map
• any future route without a local app bar must be marked shell-owned explicitly
• Rollback plan:
  • revert this PR

Testing

• Unit tests:
  • navigation provider route ownership coverage
• Integration tests:
  • minimal router widget test for shell-owned root, route-owned root, and nested route-owned flow
• Manual testing:
  • not run

Deployment Notes

• Config changes:
  • none
• Order of deployment:
  • standard

Related Commits

• fix(shell): prevent duplicate route headers

Notes

• Review the exact ownership map in navigation_provider.dart if additional shell-mounted routes are expected.

Closes #398

[github-actions]

Plugin Module Size Gate

Policy: modules over 3 MB must be delivered as plugins; plugin modules over 5 MB must document cache management.

Module	Size	Type	Status
No changed Dart/Flutter modules detected	n/a	n/a	OK

[github-actions]

🚀 PR Quick Check Summary

Check	Status	Description
PR Validation	❌ failure	Title format, docs, bundled model guardrail
Code Quality	❌ cancelled	Analyze, formatting
Core Tests	✅ success	Core package unit tests

💡 Note: Full app tests, coverage reports, and security scans run on merge to main.

View Details

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

🚀 PR Quick Check Summary

Check	Status	Description
PR Validation	✅ success	Title format, docs, bundled model guardrail
Code Quality	❌ failure	Analyze, formatting
Core Tests	✅ success	Core package unit tests

💡 Note: Full app tests, coverage reports, and security scans run on merge to main.

View Details