Enhance: Add confirmation dialog system for destructive actions #261
Conversation
- Created `web/contexts/ConfirmContext.tsx` with Promise-based API - Created `web/components/ui/ConfirmDialog.tsx` with dual-theme support - Integrated `ConfirmProvider` into `web/App.tsx` - Refactored `web/pages/GroupDetails.tsx` to replace `window.confirm` with `useConfirm` - Improved `Modal` accessibility by adding `role="dialog"` and `aria-modal="true"` - Verified with Playwright tests
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for split-but-wiser ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Implemented a complete confirmation dialog system to replace native
window.confirmalerts.Key changes:
ConfirmContext: Exposes aconfirm()function that returns a Promise, making it easy to use in async handlers (e.g.,if (await confirm(...))).ConfirmDialog: A reusable component built on top of the existingModal, supporting both Neobrutalism and Glassmorphism themes.GroupDetails.tsxto use the new system for deleting expenses, deleting groups, leaving groups, and removing members.role="dialog") to the baseModalcomponent.This improves the UX by keeping the user within the application's theming and provides a safer, more consistent way to handle destructive actions.
PR created automatically by Jules for task 11521365444512383611 started by @Devasy23