Update log4net from 3.3.2 to 3.4.0 - #3
Open
FreeAndNil wants to merge 1 commit into
Open
Conversation
All nine Logging scenarios still validate as Supported. Measured on an i5-9500 with two runs per arm. Only allocations are quoted: timing on that machine drifted up to 19% between identical builds, which is wider than any effect the upgrade has. SimpleMessage, StructuredProperties, ExceptionLogging, TemplateRendering and BufferedLogging each allocate 8 bytes less per operation. ScopeOrContext allocates 48 bytes more, 848 to 896, and is the one regression. Both 3.4.0 runs agree, and the 848 baseline is confirmed by the committed GitHub runner report as well as locally. The suspect is the LogicalThreadContextProperties setter rewrite in 3.4.0, but a standalone repro outside the matrix has not been found, so the cause is still open upstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All nine Logging scenarios still validate as Supported. Measured on an i5-9500 with two runs per arm. Only allocations are quoted: timing on that machine drifted up to 19% between identical builds, which is wider than any effect the upgrade has.
SimpleMessage, StructuredProperties, ExceptionLogging, TemplateRendering and BufferedLogging each allocate 8 bytes less per operation. ScopeOrContext allocates 48 bytes more, 848 to 896, and is the one regression. Both 3.4.0 runs agree, and the 848 baseline is confirmed by the committed GitHub runner report as well as locally. The suspect is the LogicalThreadContextProperties setter rewrite in 3.4.0, but a standalone repro outside the matrix has not been found, so the cause is still open upstream.