-
-
Notifications
You must be signed in to change notification settings - Fork 4
fix(netlify): deliver env vars to SSR runtime via .env generation at build time #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9545943
perf(sessions): move heartbeat from DB writes to Redis sorted set
LesiaUKR 6a76a87
Merge branch 'develop' into sl/feat/db-optimization
LesiaUKR 6b4dfec
fix(db): require explicit APP_ENV and add runtime env diagnostics
LesiaUKR 35a423e
fix(db): replace APP_ENV throw with runtime env diagnostics for Netli…
LesiaUKR 8aef55f
Merge branch 'develop' into sl/feat/db-optimization
LesiaUKR 03dee65
fix(deploy): inline all server env vars at build time for Netlify SSR…
LesiaUKR 10dbd14
Merge branch 'develop' into sl/feat/db-optimization
LesiaUKR 12d4439
fix(deploy): add netlify-plugin-bundle-env to inject env vars into SS…
LesiaUKR 7b9212b
fix(deploy): typo fix
LesiaUKR 3355103
Merge branch 'develop' into sl/feat/db-optimization
LesiaUKR 50c6789
fix(netlify): deliver env vars to SSR runtime via .env generation at …
LesiaUKR 2510901
fix(netlify): generate allowlist-based .env for SSR runtime env vars
LesiaUKR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,10 @@ | ||
| [build] | ||
| base = "frontend" | ||
| command = "npm ci --include=optional && npm run build" | ||
| command = "printenv > .env && npm ci --include=optional && npm run build" | ||
| publish = ".next" | ||
|
|
||
| [build.environment] | ||
| NODE_VERSION = "20.19.0" | ||
|
|
||
| [[plugins]] | ||
| package = "@netlify/plugin-nextjs" | ||
|
|
||
| [[plugins]] | ||
| package = "netlify-plugin-bundle-env" | ||
| package = "@netlify/plugin-nextjs" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.