(SP: 1) [FIX] Add netlify-plugin-bundle-env for Netlify SSR env var delivery#426
(SP: 1) [FIX] Add netlify-plugin-bundle-env for Netlify SSR env var delivery#426ViktorSvertoka merged 8 commits intodevelopfrom
Conversation
fix(about): update LinkedIn follower fallback to 1800
LesiaUKR
requested review from
AM1007,
ViktorSvertoka and
liudmylasovetovs
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
📝 WalkthroughWalkthroughLayout now concurrently fetches blog categories via Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/app/`[locale]/layout.tsx:
- Around line 28-31: The parallel fetch currently uses Promise.all so a
rejection from getCachedBlogCategories aborts the whole layout; change the logic
to treat blogCategories as optional by catching errors from
getCachedBlogCategories (or using Promise.allSettled) and defaulting
blogCategories to [] on failure while still throwing or propagating errors from
getMessages, and log the error; update the code around the Promise.all call that
assigns [messages, blogCategories] so AppChrome always receives an array
(possibly empty) for blogCategories instead of letting a DB rejection bubble up.
In `@frontend/next.config.ts`:
- Around line 8-12: The current next.config.ts mirrors process.env into
nextConfig.env using Object.fromEntries(process.env), which both causes Next.js
build errors for reserved keys (e.g., NODE_ENV, NEXT_RUNTIME) and leaks
server-only secrets to the client; remove this env mirroring entirely (delete
the env: Object.fromEntries(...) block) and instead rely on server-side
process.env access in App Router/server components for secrets, and only expose
client-safe values via NEXT_PUBLIC_* (if any) by referencing
process.env.NEXT_PUBLIC_* at build/runtime rather than injecting a blanket env
object; ensure code paths that used nextConfig.env are updated to read
process.env directly (e.g., code in frontend/proxy.ts,
frontend/lib/security/csrf.ts, frontend/lib/shop/status-token.ts,
frontend/lib/email/transporter.ts) so secrets remain server-only.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d96bba41-c318-4699-853b-6579bf1a317e
📒 Files selected for processing (2)
frontend/app/[locale]/layout.tsxfrontend/next.config.ts
| const [messages, blogCategories] = await Promise.all([ | ||
| getMessages({ locale }), | ||
| getCachedBlogCategories(locale), | ||
| ]); |
There was a problem hiding this comment.
Don't let blog-category lookup reintroduce global 500s.
getCachedBlogCategories() is just a cached DB wrapper with no fallback, so one rejection here aborts the entire locale layout again. Since blogCategories is optional in AppChrome, this should degrade to [] instead of taking down dashboard/auth/leaderboard pages that don't need blog nav data to render.
💡 Suggested fix
- const [messages, blogCategories] = await Promise.all([
- getMessages({ locale }),
- getCachedBlogCategories(locale),
- ]);
+ const [messagesResult, blogCategoriesResult] = await Promise.allSettled([
+ getMessages({ locale }),
+ getCachedBlogCategories(locale),
+ ]);
+
+ if (messagesResult.status === 'rejected') throw messagesResult.reason;
+
+ const messages = messagesResult.value;
+ const blogCategories =
+ blogCategoriesResult.status === 'fulfilled'
+ ? blogCategoriesResult.value
+ : [];🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@frontend/app/`[locale]/layout.tsx around lines 28 - 31, The parallel fetch
currently uses Promise.all so a rejection from getCachedBlogCategories aborts
the whole layout; change the logic to treat blogCategories as optional by
catching errors from getCachedBlogCategories (or using Promise.allSettled) and
defaulting blogCategories to [] on failure while still throwing or propagating
errors from getMessages, and log the error; update the code around the
Promise.all call that assigns [messages, blogCategories] so AppChrome always
receives an array (possibly empty) for blogCategories instead of letting a DB
rejection bubble up.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/db/index.ts`:
- Line 29: Remove the stray leading character before the declaration: change the
malformed token "0const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB
=== '1';" to a valid const declaration "const STRICT_LOCAL_DB_GUARD =
process.env.SHOP_STRICT_LOCAL_DB === '1';" so the module parses and the
SHOP_STRICT_LOCAL_DB guard (STRICT_LOCAL_DB_GUARD) can run; after fixing, run
TypeScript/ESLint or a quick build to confirm no other syntax errors remain.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dbee9dbb-bb15-46a9-b5b2-4299abc4f561
📒 Files selected for processing (3)
frontend/db/index.tsfrontend/next.config.tsnetlify.toml
💤 Files with no reviewable changes (1)
- frontend/next.config.ts
✅ Files skipped from review due to trivial changes (1)
- netlify.toml
| const IS_LOCAL_ENV = APP_ENV === 'local'; | ||
|
|
||
| const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1'; | ||
| 0const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1'; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Show the malformed declaration in context and scan for similar accidental prefixes.
sed -n '24,32p' frontend/db/index.ts
rg -nP '^\s*\d+const\b' --type tsRepository: DevLoversTeam/devlovers.net
Length of output: 398
Remove the stray 0 before const.
Line 29 is a hard syntax error (0const), so frontend/db/index.ts will not parse. This prevents the DB module from loading before the Netlify env fallback or the SHOP_STRICT_LOCAL_DB guard can run, which can bring back SSR 500s across DB-backed pages and also bypass the local-test safety check used by frontend/playwright.config.ts:27 and frontend/lib/tests/shop/setup.ts:39.
Suggested fix
-0const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1';
+const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1';📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 0const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1'; | |
| const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1'; |
🧰 Tools
🪛 Biome (2.4.9)
[error] 29-29: Expected a statement but instead found '0const STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1''.
(parse)
[error] 29-29: numbers cannot be followed by identifiers directly after
(parse)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@frontend/db/index.ts` at line 29, Remove the stray leading character before
the declaration: change the malformed token "0const STRICT_LOCAL_DB_GUARD =
process.env.SHOP_STRICT_LOCAL_DB === '1';" to a valid const declaration "const
STRICT_LOCAL_DB_GUARD = process.env.SHOP_STRICT_LOCAL_DB === '1';" so the module
parses and the SHOP_STRICT_LOCAL_DB guard (STRICT_LOCAL_DB_GUARD) can run; after
fixing, run TypeScript/ESLint or a quick build to confirm no other syntax errors
remain.
2 participants
Goal
Fix all SSR page crashes on Netlify develop deploy caused by environment variables not reaching serverless function runtime.
Scope
netlify-plugin-bundle-envplugin tonetlify.toml— embeds env vars into serverless functions during build, as recommended by Netlify docsenvblock fromnext.config.tsthat inlined server secrets into client-side bundlesdb/index.tsuntil fix is confirmedContext
Netlify does not deliver dashboard env vars to Next.js SSR runtime — this is a known platform limitation (opennextjs/opennextjs-netlify#2754). The official workaround is
netlify-plugin-bundle-env, which injects env vars into function bundles at build time.Expected impact
All 28 SSR pages (blog, quizzes, leaderboard, dashboard, shop, auth, admin) should work on Netlify develop deploy.
Out of scope
Summary by CodeRabbit