Skip to content

Toolbar: add allowKeyboardNavigation and update KBN article#8976

Open
vladaskorohodova wants to merge 7 commits into
mainfrom
feature/26_2_toolbar-kbn-improvement
Open

Toolbar: add allowKeyboardNavigation and update KBN article#8976
vladaskorohodova wants to merge 7 commits into
mainfrom
feature/26_2_toolbar-kbn-improvement

Conversation

@vladaskorohodova

Copy link
Copy Markdown
Collaborator

No description provided.

@vladaskorohodova vladaskorohodova self-assigned this Jul 13, 2026
Copilot AI review requested due to automatic review settings July 13, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents the new dxToolbar option allowKeyboardNavigation and updates the Toolbar accessibility guidance to reflect the keyboard interaction model when this option is enabled.

Changes:

  • Added an API reference page for dxToolbar.Options.allowKeyboardNavigation.
  • Updated the Toolbar “Keyboard Navigation” article with revised key behaviors and a prerequisite link to the option.
  • Extended metadata/syntax-data.json with the Vue kebab-case mapping for allowKeyboardNavigation.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
metadata/syntax-data.json Adds the Vue attribute mapping for dxToolbarOptions.allowKeyboardNavigation.
concepts/05 UI Components/Toolbar/05 Accessibility/15 Keyboard Navigation.md Updates the keyboard navigation documentation and references allowKeyboardNavigation.
api-reference/10 UI Components/dxToolbar/1 Configuration/allowKeyboardNavigation.md Introduces the API reference entry describing the option’s behavior and default.

Comment thread concepts/05 UI Components/Toolbar/05 Accessibility/15 Keyboard Navigation.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 11:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comment thread concepts/05 UI Components/Toolbar/05 Accessibility/15 Keyboard Navigation.md Outdated
Comment thread concepts/05 UI Components/Toolbar/05 Accessibility/15 Keyboard Navigation.md Outdated
Comment thread concepts/05 UI Components/Toolbar/05 Accessibility/15 Keyboard Navigation.md Outdated
Copilot AI review requested due to automatic review settings July 13, 2026 11:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread concepts/05 UI Components/Toolbar/05 Accessibility/15 Keyboard Navigation.md Outdated
Comment thread concepts/05 UI Components/Toolbar/05 Accessibility/15 Keyboard Navigation.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 11:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 11:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

---
---
##### shortDescription
Specifies whether the Toolbar manages keyboard navigation between the items.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"toolbar manages navigation" sounds a little vague. Suppose it doesn't manage navigation. But then maybe something else manages that navigation? We better specifically say what's available to end-users.

Suggested change
Specifies whether the Toolbar manages keyboard navigation between the items.
Specifies whether users navigate between Toolbar items using standard keyboard shortcuts.

Specifies whether the Toolbar manages keyboard navigation between the items.

---
When this property is set to `true`, the Toolbar uses keyboard patterns that match [WAI-ARIA Authoring Practices (APG)](https://www.w3.org/WAI/ARIA/apg/patterns/toolbar/) recommendations. Users can move focus between available items with arrow keys and the `Home` and `End` keys. The `Tab` and `Shift+Tab` keys move focus into and out of the Toolbar.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if "patterns" is part of some standard accessibility terminology. But I would say "shortcuts" instead to make it simpler for majority of readers.

Suggested change
When this property is set to `true`, the Toolbar uses keyboard patterns that match [WAI-ARIA Authoring Practices (APG)](https://www.w3.org/WAI/ARIA/apg/patterns/toolbar/) recommendations. Users can move focus between available items with arrow keys and the `Home` and `End` keys. The `Tab` and `Shift+Tab` keys move focus into and out of the Toolbar.
When this property is set to `true`, the Toolbar enables keyboard shortcuts that match [WAI-ARIA Authoring Practices (APG)](https://www.w3.org/WAI/ARIA/apg/patterns/toolbar/) recommendations. Users can move focus between available items with arrow keys and the `Home` and `End` keys. The `Tab` and `Shift+Tab` keys move focus into and out of the Toolbar.

---
When this property is set to `true`, the Toolbar uses keyboard patterns that match [WAI-ARIA Authoring Practices (APG)](https://www.w3.org/WAI/ARIA/apg/patterns/toolbar/) recommendations. Users can move focus between available items with arrow keys and the `Home` and `End` keys. The `Tab` and `Shift+Tab` keys move focus into and out of the Toolbar.

When this property is set to `false`, the Toolbar does not process item-to-item keyboard movement, and each focusable item participates in the page tab order according to its settings. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When this property is set to `false`, the Toolbar does not process item-to-item keyboard movement, and each focusable item participates in the page tab order according to its settings.
When this property is set to `false`, the Toolbar does not process item-to-item keyboard shortcuts. Each focusable item participates in the page tab order according to its settings.

<tr>
<td>Shift + Tab</td>
<td>Moves focus to the previous toolbar item.</td>
<td>Moves focus to the last Toolbar item or to the previous focusable element before the Toolbar.</td>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td>Moves focus to the last Toolbar item or to the previous focusable element before the Toolbar.</td>
<td>If a Toolbar receives focus, it focuses its last available item.</td>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants