Fix CI detection operator and remove unused parameter in Node runner#32809
Merged
nightskylark merged 2 commits intokill-dotnet-runnerfrom Mar 5, 2026
Merged
Fix CI detection operator and remove unused parameter in Node runner#32809nightskylark merged 2 commits intokill-dotnet-runnerfrom
nightskylark merged 2 commits intokill-dotnet-runnerfrom
Conversation
…teVectorMapConsoleApp Co-authored-by: nightskylark <2280467+nightskylark@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove .NET dependency from DevExtreme QUnit runner
Fix CI detection operator and remove unused parameter in Node runner
Mar 5, 2026
nightskylark
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two correctness issues in the Node.js QUnit runner identified in code review.
Changes
utils.ts—isContinuousIntegration: Replace??with||so an emptyCCNetWorkingDirectory=""doesn't short-circuit before checkingDEVEXTREME_TEST_CI.??only falls through onnull/undefined;||matches the original C#!IsNullOrEmpty(A) || !IsNullOrEmpty(B)semantics.vectormap.ts+index.ts—executeVectorMapConsoleApp: Remove the unusedarg: stringparameter from the interface, implementation, and call site. The URL path capture group was extracted but never consumed inside the function.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.