Skip to content

Fix CI detection operator and remove unused parameter in Node runner#32809

Merged
nightskylark merged 2 commits intokill-dotnet-runnerfrom
copilot/sub-pr-32792
Mar 5, 2026
Merged

Fix CI detection operator and remove unused parameter in Node runner#32809
nightskylark merged 2 commits intokill-dotnet-runnerfrom
copilot/sub-pr-32792

Conversation

Copy link
Contributor

Copilot AI commented Mar 5, 2026

Two correctness issues in the Node.js QUnit runner identified in code review.

Changes

  • utils.tsisContinuousIntegration: Replace ?? with || so an empty CCNetWorkingDirectory="" doesn't short-circuit before checking DEVEXTREME_TEST_CI. ?? only falls through on null/undefined; || matches the original C# !IsNullOrEmpty(A) || !IsNullOrEmpty(B) semantics.
// Before — silent failure when CCNetWorkingDirectory=""
return Boolean(process.env.CCNetWorkingDirectory ?? process.env.DEVEXTREME_TEST_CI);

// After
return Boolean(process.env.CCNetWorkingDirectory || process.env.DEVEXTREME_TEST_CI);
  • vectormap.ts + index.tsexecuteVectorMapConsoleApp: Remove the unused arg: string parameter from the interface, implementation, and call site. The URL path capture group was extracted but never consumed inside the function.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…teVectorMapConsoleApp

Co-authored-by: nightskylark <2280467+nightskylark@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove .NET dependency from DevExtreme QUnit runner Fix CI detection operator and remove unused parameter in Node runner Mar 5, 2026
@nightskylark nightskylark marked this pull request as ready for review March 5, 2026 16:27
@nightskylark nightskylark merged commit 6fbc970 into kill-dotnet-runner Mar 5, 2026
@nightskylark nightskylark deleted the copilot/sub-pr-32792 branch March 5, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants