Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion .github/workflows/vale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,31 @@ jobs:
ssh-key: ${{ secrets.VALE_STYLES_ACCESS_KEY }}
- name: copy vale rules to the root repo
run: shopt -s dotglob && cp -r ./vale-styles/vale/* .

- name: detect README file
id: detect
shell: bash
run: |
set -euo pipefail

found="$(find . -maxdepth 1 -type f -iname 'readme.md' -print | head -n 1 || true)"

if [[ -z "$found" ]]; then
echo "No README.md found in repo root. Nothing to lint."
echo "files=[]" >> "$GITHUB_OUTPUT"
exit 0
fi

found="${found#./}"

echo "Found README: $found"
echo "files=[\"$found\"]" >> "$GITHUB_OUTPUT"

- name: vale linter check
if: steps.detect.outputs.files != '[]'
uses: DevExpress/vale-action@reviewdog
with:
files: '["[Rr]eadme.md"]'
files: ${{ steps.detect.outputs.files }}
fail_on_error: true
filter_mode: nofilter
reporter: github-check
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<!-- default badges list -->
![](https://img.shields.io/endpoint?url=https://codecentral.devexpress.com/api/v1/VersionRange/340354634/25.2.2%2B)
[![](https://img.shields.io/badge/Open_in_DevExpress_Support_Center-FF7200?style=flat-square&logo=DevExpress&logoColor=white)](https://supportcenter.devexpress.com/ticket/details/T1129779)
[![](https://img.shields.io/badge/📖_How_to_use_DevExpress_Examples-e9f6fc?style=flat-square)](https://docs.devexpress.com/GeneralInformation/403183)
[![](https://img.shields.io/badge/💬_Leave_Feedback-feecdd?style=flat-square)](#does-this-example-address-your-development-requirementsobjectives)
Expand Down Expand Up @@ -38,15 +37,15 @@

- link
- link
- ...

Check failure on line 40 in README.md

View workflow job for this annotation

GitHub Actions / vale

[vale] README.md#L40

[DX.Typography] Consider using the '…' symbol instead of '...'.
Raw output
{"message": "[DX.Typography] Consider using the '…' symbol instead of '...'.", "location": {"path": "README.md", "range": {"start": {"line": 40, "column": 3}}}, "severity": "ERROR"}

Check warning on line 40 in README.md

View workflow job for this annotation

GitHub Actions / vale

[vale] README.md#L40

[Microsoft.Ellipses] In general, don't use an ellipsis.
Raw output
{"message": "[Microsoft.Ellipses] In general, don't use an ellipsis.", "location": {"path": "README.md", "range": {"start": {"line": 40, "column": 3}}}, "severity": "WARNING"}

## More Examples

- link
- link
- ...

Check warning on line 46 in README.md

View workflow job for this annotation

GitHub Actions / vale

[vale] README.md#L46

[Microsoft.Ellipses] In general, don't use an ellipsis.
Raw output
{"message": "[Microsoft.Ellipses] In general, don't use an ellipsis.", "location": {"path": "README.md", "range": {"start": {"line": 46, "column": 3}}}, "severity": "WARNING"}

Check failure on line 46 in README.md

View workflow job for this annotation

GitHub Actions / vale

[vale] README.md#L46

[DX.Typography] Consider using the '…' symbol instead of '...'.
Raw output
{"message": "[DX.Typography] Consider using the '…' symbol instead of '...'.", "location": {"path": "README.md", "range": {"start": {"line": 46, "column": 3}}}, "severity": "ERROR"}
<!-- feedback -->
## Does this example address your development requirements/objectives?

Check failure on line 48 in README.md

View workflow job for this annotation

GitHub Actions / vale

[vale] README.md#L48

[DX.HeadingCapitalization] 'Does this example address your development requirements/objectives?' should match our guidelines for title case
Raw output
{"message": "[DX.HeadingCapitalization] 'Does this example address your development requirements/objectives?' should match our guidelines for title case", "location": {"path": "README.md", "range": {"start": {"line": 48, "column": 4}}}, "severity": "ERROR"}

Check failure on line 48 in README.md

View workflow job for this annotation

GitHub Actions / vale

[vale] README.md#L48

[DX.HeadingPunctuation] Don't use end punctuation at the end of headings.
Raw output
{"message": "[DX.HeadingPunctuation] Don't use end punctuation at the end of headings.", "location": {"path": "README.md", "range": {"start": {"line": 48, "column": 69}}}, "severity": "ERROR"}

[<img src="https://www.devexpress.com/support/examples/i/yes-button.svg"/>](https://www.devexpress.com/support/examples/survey.xml?utm_source=github&utm_campaign=devextreme-examples-template&~~~was_helpful=yes) [<img src="https://www.devexpress.com/support/examples/i/no-button.svg"/>](https://www.devexpress.com/support/examples/survey.xml?utm_source=github&utm_campaign=devextreme-examples-template&~~~was_helpful=no)

Expand Down
2 changes: 1 addition & 1 deletion jQuery/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions jQuery/src/data.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const count = 0;
2 changes: 1 addition & 1 deletion jQuery/src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<link rel="stylesheet" type="text/css" href="index.css" />
<script type="text/javascript" src="../node_modules/jquery/dist/jquery.js"></script>
<script type="text/javascript" src="../node_modules/devextreme-dist/js/dx.all.js"></script>
<script type="text/javascript" src="index.js"></script>
<script type="module" src="index.js"></script>
</head>

<body class="dx-viewport">
Expand Down
4 changes: 3 additions & 1 deletion jQuery/src/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { count as initialCount } from './data.js';

$(() => {
let count = 0;
let count = initialCount;
$('#btn').dxButton({
text: `Click count: ${count}`,
onClick(e) {
Expand Down
Loading