Skip to content

test(cli): isolate install plan receipt fixture #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaiyer wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −9
Open

test(cli): isolate install plan receipt fixture #1149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions tests/test_cli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2388,6 +2388,11 @@ TEST(cli_install_plan_receipt_no_mutation_issue388) {
if (!cbm_mkdtemp(tmpdir))
FAIL("cbm_mkdtemp failed");

/* Production correctly honors CODEX_HOME, but this fixture must not inherit
* the developer or CI runner's real Codex home. */
char *saved_codex_home = save_test_env("CODEX_HOME");
cbm_unsetenv("CODEX_HOME");

/* Make Cursor + Codex "detected". */
char dir[512];
snprintf(dir, sizeof(dir), "%s/.cursor", tmpdir);
Expand All @@ -2396,24 +2401,26 @@ TEST(cli_install_plan_receipt_no_mutation_issue388) {
test_mkdirp(dir);

char *json = cbm_build_install_plan_json(tmpdir, "/usr/local/bin/codebase-memory-mcp");
ASSERT_NOT_NULL(json);
ASSERT(strstr(json, "agent.install.plan.v1") != NULL);
ASSERT(strstr(json, "writes_started") != NULL);
ASSERT(strstr(json, "next_safe_command") != NULL);
ASSERT(strstr(json, "cursor") != NULL);
ASSERT(strstr(json, ".cursor/mcp.json") != NULL);
ASSERT(strstr(json, ".codex/config.toml") != NULL);
bool receipt_valid = json && strstr(json, "agent.install.plan.v1") &&
strstr(json, "writes_started") && strstr(json, "next_safe_command") &&
strstr(json, "cursor") && strstr(json, ".cursor/mcp.json") &&
strstr(json, ".codex/config.toml");
free(json);

/* Critical: building the plan must NOT have created any config file. */
char cfg[512];
struct stat st;
snprintf(cfg, sizeof(cfg), "%s/.cursor/mcp.json", tmpdir);
ASSERT(stat(cfg, &st) != 0); /* must not exist */
bool cursor_untouched = stat(cfg, &st) != 0;
snprintf(cfg, sizeof(cfg), "%s/.codex/config.toml", tmpdir);
ASSERT(stat(cfg, &st) != 0); /* must not exist */
bool codex_untouched = stat(cfg, &st) != 0;

restore_test_env("CODEX_HOME", saved_codex_home);
test_rmdir_r(tmpdir);
if (!receipt_valid)
FAIL("install plan receipt must describe the detected Cursor and Codex fixtures");
if (!cursor_untouched || !codex_untouched)
FAIL("building an install plan must not create agent config files");
PASS();
}

Expand Down
Loading