Skip to content

Support flake-schemas 0.3.0 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavderdrache merged 4 commits into from
Mar 10, 2026
Merged

Support flake-schemas 0.3.0 #8

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbffd67
Support flake-schemas 0.3.0
gustavderdrache Feb 27, 2026
65a5313
Flesh out comment regarding legacy behavior
gustavderdrache Mar 10, 2026
090f1cd
Discard string context for drvPath
gustavderdrache Mar 10, 2026
79a8aad
Extend corpus with 0.1.4 and 0.3.0 behaviors
gustavderdrache Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 52 additions & 29 deletions flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
inputs.flake.url = "https://flakehub.com/f/DeterminateSystems/flake-schemas/*";

outputs = inputs:
let
getFlakeOutputs = flake: includeOutputPaths:
Expand All @@ -9,13 +10,24 @@

mapAttrsToList = f: attrs: map (name: f name attrs.${name}) (builtins.attrNames attrs);

getAttrFromPath = paths: obj:
let
length = builtins.length paths - 1;

go = acc: index:
if index > length
then acc
else go acc.${builtins.elemAt paths index} (index + 1);
in
go obj 0;

try = e: default:
let res = builtins.tryEval e;
in if res.success then res.value else default;

mkChildren = children: { inherit children; };

flakeSchemasFlakePinned = "https://api.flakehub.com/f/pinned/DeterminateSystems/flake-schemas/0.1.4/0190e653-dd76-70bd-ba6e-a3f5eaf3d415/source.tar.gz?narHash=sha256-efoDF3VaZHpcwFd2Y1axGLqNX/ou9kDL7z9mWNqzv9w%3D";
flakeSchemasFlakePinned = "https://api.flakehub.com/f/pinned/DeterminateSystems/flake-schemas/0.3.0/019c9f61-e746-760e-a1fe-53f05b10d026/source.tar.gz?narHash=sha256-hcUPpu25%2BVLvQsf961cu4zTeA//Ab35MaMjqSS/Ojqc%3D";
in

rec {
Expand Down Expand Up @@ -52,53 +64,64 @@
uncheckedOutputs =
builtins.filter (outputName: ! schemas ? ${outputName}) (builtins.attrNames flake.outputs);

inventoryFor = filterFun:
inventoryFor =
filterFun:
builtins.mapAttrs
(outputName: schema:
(
outputName: schema:
let
doFilter = attrs:
if filterFun attrs
then
if attrs ? children
then
mkChildren (builtins.mapAttrs (childName: child: doFilter child) attrs.children)
doFilter =
attrs: output:
if filterFun attrs then
if attrs ? children then
mkChildren
(
builtins.mapAttrs (childName: child: doFilter child output.${childName}) attrs.children
)
Comment on lines +73 to +80
Copy link
Copy Markdown
Member

@grahamc grahamc Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real change here is passing attrs.children to doFilter inside mapAttrs.

else
{
forSystems = attrs.forSystems or null;
shortDescription = attrs.shortDescription or null;
what = attrs.what or null;
#evalChecks = attrs.evalChecks or {};
} // (
if includeOutputPaths then
{
derivation =
if attrs ? derivation
then builtins.unsafeDiscardStringContext attrs.derivation.drvPath
}
// (
if
includeOutputPaths then
let
drv =
if attrs?derivationAttrPath
then getAttrFromPath attrs.derivationAttrPath output
# TODO: remove when no longer needed
else if attrs?derivation
then attrs.derivation
else null;
in
{
derivation = if drv != null then drv.drvPath else null;
outputs =
if attrs ? derivation
then
if drv != null then
builtins.listToAttrs
(
builtins.map
(outputName:
{
name = outputName;
value = attrs.derivation.${outputName}.outPath;
}
)
attrs.derivation.outputs
)
else
null;
(outputName: {
name = outputName;
value = drv.${outputName}.outPath;
})
drv.outputs
) else null;
Comment on lines +91 to +114
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Guard derivation path dereferences to prevent full inventory evaluation failure.

Line 93, Line 100, and Line 108 can throw when a path is stale or resolves to a non-derivation value. That makes includingOutputPaths fail hard instead of returning nullable metadata for the problematic node.

🛡️ Suggested hardening patch 
-                              drv =
-                                if attrs?derivationAttrPath
-                                then getAttrFromPath attrs.derivationAttrPath output
+                              drv =
+                                if attrs ? derivationAttrPath
+                                then try (getAttrFromPath attrs.derivationAttrPath output) null
                                 # TODO: remove when no longer needed
-                                else if attrs?derivation
+                                else if attrs ? derivation
                                 then attrs.derivation
                                 else null;
                             in
                             {
-                              derivation = if drv != null then drv.drvPath else null;
+                              derivation = try (if drv != null then drv.drvPath else null) null;
                               outputs =
-                                if drv != null then
-                                  builtins.listToAttrs
-                                    (
-                                      builtins.map
-                                        (outputName: {
-                                          name = outputName;
-                                          value = drv.${outputName}.outPath;
-                                        })
-                                        drv.outputs
-                                    ) else null;
+                                try (
+                                  if drv != null then
+                                    builtins.listToAttrs
+                                      (
+                                        builtins.map
+                                          (outputName: {
+                                            name = outputName;
+                                            value = drv.${outputName}.outPath;
+                                          })
+                                          drv.outputs
+                                      )
+                                  else null
+                                ) null;
                             }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
drv =
if attrs?derivationAttrPath
then getAttrFromPath attrs.derivationAttrPath output
# TODO: remove when no longer needed
else if attrs?derivation
then attrs.derivation
else null;
in
{
derivation = if drv != null then drv.drvPath else null;
outputs =
if attrs ? derivation
then
if drv != null then
builtins.listToAttrs
(
builtins.map
(outputName:
{
name = outputName;
value = attrs.derivation.${outputName}.outPath;
}
)
attrs.derivation.outputs
)
else
null;
(outputName: {
name = outputName;
value = drv.${outputName}.outPath;
})
drv.outputs
) else null;
drv =
if attrs ? derivationAttrPath
then try (getAttrFromPath attrs.derivationAttrPath output) null
# TODO: remove when no longer needed
else if attrs ? derivation
then attrs.derivation
else null;
in
{
derivation = try (if drv != null then drv.drvPath else null) null;
outputs =
try (
if drv != null then
builtins.listToAttrs
(
builtins.map
(outputName: {
name = outputName;
value = drv.${outputName}.outPath;
})
drv.outputs
)
else null
) null;
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@flake.nix` around lines 91 - 111, The code dereferences
attrs.derivationAttrPath, attrs.derivation and fields on drv (drv.drvPath,
drv.outputs, drv.${outputName}.outPath) without guarding, which can throw and
make includingOutputPaths fail; fix by validating before access (e.g. use
builtins.hasAttr / builtins.tryEval or builtins.isDerivation where available) so
drv is only treated as a derivation when it actually has drvPath and outputs,
and when mapping outputs check each outputName exists on drv before reading
drv.${outputName}.outPath; update the branches that compute drv and the
derivation/outputs results to return null/nullable metadata when validation
fails instead of performing direct dereferences.

}
else
{ }
)
else
{ };
in
doFilter ((schema.inventory or (output: { })) flake.outputs.${outputName})
doFilter
((schema.inventory or (output: { }))
flake.outputs.${outputName}
)
flake.outputs.${outputName}

)
schemas;

Expand Down