feat(testing): visual-regression public docs + dogfood + APPROVE_PROPERTY (Track N N2-N4)#127
Merged
Merged
Conversation
…ERTY (Track N N2-N4, @SInCE 1.6.9) Completes the public visual-regression surface introduced in #126: - expose PdfVisualRegression.APPROVE_PROPERTY (@SInCE 1.6.9) so consumers toggle approve mode without hard-coding the system-property string (mirrors LayoutSnapshotAssertions.UPDATE_PROPERTY) - add docs/operations/visual-regression-testing.md (pixel vs semantic, API, approve mode, cross-platform tolerance calibration) - README 'Which API should I use?' gains a pixel-level visual-regression row - add PublicVisualApiDogfoodTest: composes a document and pixel-tests it end-to-end through the public testing.visual surface Full suite 1060/1060 green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track N / N2–N4 — complete the public visual-regression surface (cycle 1.6.9)
Follow-up to #126 (which promoted
PdfVisualRegression+ImageDiffto public API). This PR adds the docs, the consumer dogfood test, and the approve-mode property constant so the surface is cut-ready.What changed
PdfVisualRegression.APPROVE_PROPERTY(@since 1.6.9) — exposes thegraphcompose.visual.approvesystem-property name so consumers toggle approve mode without hard-coding the string (mirrorsLayoutSnapshotAssertions.UPDATE_PROPERTY);approveMode()+ the failure message now reference it.docs/operations/visual-regression-testing.md: pixel-vs-semantic guidance, thePdfVisualRegressionAPI + immutable-setter table, approve mode, baseline/sidecar layout, and cross-platform tolerance calibration (defaultstolerance 6/budget 0; repo CV-parity uses8/50_000for Windows-baseline ↔ Linux-CI drift).PublicVisualApiDogfoodTest: composes a document via the public DSL and pixel-tests it end-to-end through the publiccom.demcha.compose.testing.visualsurface (approve → match → assert baseline + no sidecar), using the newAPPROVE_PROPERTY. Sibling toLayoutSnapshotPublicApiDogfoodTest.Verification
PdfVisualRegressionTestunaffected by theAPPROVE_PROPERTYrename).## v1.6.9 — Planned(### Public API+### Documentation).Deferred
<subpackages>to includecom.demcha.compose.testingso the public testing helpers (layout+visual) get strict doclint coverage.