Add unstoppable domain resolution support#9
Open
wizlee wants to merge 4 commits intoDeltaEngine:masterfrom
Open
Add unstoppable domain resolution support#9wizlee wants to merge 4 commits intoDeltaEngine:masterfrom
wizlee wants to merge 4 commits intoDeltaEngine:masterfrom
Conversation
- Was trying not to use it because it is used very sparringly in the project
Author
|
Related to #8 . Find out that able to create a PR from fork. |
|
It should be possible to get the needed information from the domain by using resolution#addr only. In case if the domain is not registered, a record is not found, or this domain is not supported (not a domain) the library will throw a corresponding error. You can catch that one and proceed with the rest of the logic. This change can speed up the process as it requires only 1 network call instead of 2. Also, it is a great UX when the resolved address is shown under the domain once it is resolved. Other than those 2 points above the PR looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots for success scenarios
Screenshots for error scenarios