Feat/UI and or toggle#6
Merged
Merged
Conversation
- Panel toolbar (shown under Details): segmented OR/AND control + a 'Complete cases only' checkbox revealed under AND; OR/AND on the left, Details on the right. - OR is unchanged. AND counts only NARROWED filters (a filter left at its default is a no-op), so an un-narrowed AND shows the full graph instead of emptying it on dirty/rounded values. - Non-strict AND (default): each conjunct OR-ed with a new 'IS MISSING' leaf, so a property an element lacks (or that belongs to the other element type) never disqualifies it. - Strict AND (complete cases): type-grouped (AND within each element type, OR between the node and edge groups) so a same-type missing value excludes while the other element type stays neutral. - Join mode + strict persist to localStorage; query text stays the source of truth (encode/decode round-trip). Adds unit + round-trip + UI tests.
- Persist filterJoinMode / filterStrict per workspace view: defaulted in createDefaultLayout and restored in parseLayouts (pre-1.15.4 files default to OR / non-strict). Export picks them up automatically. - Document the new operator/toggle: IS MISSING + OR/AND toggle in the query editor help, tour steps (rendered Details pill + OR/AND mock), API.md grammar, and ARCHITECTURE.md. - Tour: correct the canvas step — click selects + opens the tooltip, and shift+click adds/removes from the selection. - Bump version 1.15.3 -> 1.15.4 and add the CHANGELOG entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OR/AND filter join toggle
Adds an OR/AND toggle to the filter panel (under ⚙ Details) so active filters can be combined with AND, not just the default OR.
IS MISSINGquery-DSL operator to express the non-strict join; the query text stays the source of truth and round-trips through encode/decode and JSON.API.md,ARCHITECTURE.md.Test plan