Align questionnaire question-set editing with the questionnaire change permission - #15691
Merged
Merged
Conversation
The question-set editor accepted either the questionnaire add permission or the change permission, so a role holding only the create permission could rewrite the question set of any existing questionnaire and reset the completion state of every answered copy of it. The three sibling questionnaire routes each require one permission, and the user permission chart documents editing an existing questionnaire as the change permission. Creating a questionnaire no longer redirects into the question-set editor unless the caller also holds the change permission, so a create-only role lands on the questionnaire list instead of a denial page.
blakeaowens
approved these changes
Aug 17, 2026
Maffooch
approved these changes
Aug 17, 2026
devGregA
approved these changes
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening / consistency improvement to questionnaire configuration permission checks. The question-set editor now requires the same permission as the other edit operation on that object, and there is a regression test. Users with the questionnaire change permission see no functional change.
A role holding only the questionnaire add permission can still create a questionnaire. It now lands on the questionnaire list after creating one, instead of being sent to a page it cannot use.