docs(sensei): hub views, fix-quota states, and that a fix PR does not close the finding - #15684
Open
Maffooch wants to merge 3 commits into
Open
docs(sensei): hub views, fix-quota states, and that a fix PR does not close the finding#15684Maffooch wants to merge 3 commits into
Maffooch wants to merge 3 commits into
Conversation
The Sensei hub's toggle used to mix two questions: "DefectDojo-hosted" and "In-repo CI" listed onboarded repositories, while "Auto-fix Candidates" and "Scan Activity" were views across all of them. The hosted/CI choice is now a scope inside the Repositories view, so document the toggle as the three views it selects, and say plainly that candidates and activity always cover every repository. Also split the two reasons Approve can be disabled. "No fix quota on this license" and "quota exhausted" are opposite situations with different actions, and the hub previously reported both as exhaustion — which told a customer with no quota to wait for a reset that would never come. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016VjaotfrkL2f2QHvhUcbsh
A pull request changes the code, not what is running, so the finding stays open after Sensei fixes it — and for a finding that came from a cloud account, merging Terraform changes nothing the scanner reads until the infrastructure change is applied. The badge now distinguishes "PR open" from "PR merged", so document both states and what actually closes the finding. Also note that reappearances of an outstanding fix are recognised as the same issue and do not consume extra fixes, and add both to the troubleshooting list, where "why is this still open?" is the question people arrive with. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016VjaotfrkL2f2QHvhUcbsh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for the Sensei capability-views work:
Docs-only: touches docs/content/sensei/fixing_findings.md and sensei_reference.md. Base bugfix; brought current with the bugfix line.