Skip to content

🎉 Add fix_available to Harbor #13053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentijnscholten merged 4 commits into from
Aug 30, 2025
Merged

🎉 Add fix_available to Harbor #13053

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b47a395
:tada: Add fix_available to Harbor
manuel-sommer Aug 26, 2025
ad0a567
:tada: Add fix_available to Harbor
manuel-sommer Aug 26, 2025
ac2413b
remove mitigation deduplication
manuel-sommer Aug 26, 2025
5116755
Update settings.dist.py
manuel-sommer Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dojo/settings/settings.dist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,7 +1301,7 @@ def saml2_attrib_map_format(din):
"JFrog Xray Scan": ["title", "description", "component_name", "component_version"],
"CycloneDX Scan": ["vuln_id_from_tool", "component_name", "component_version"],
"SSLyze Scan (JSON)": ["title", "description"],
"Harbor Vulnerability Scan": ["title", "mitigation"],
Comment thread
manuel-sommer marked this conversation as resolved.
"Harbor Vulnerability Scan": ["title"],
"Rusty Hog Scan": ["file_path", "payload"],
"StackHawk HawkScan": ["vuln_id_from_tool", "component_name", "component_version"],
"Hydra Scan": ["title", "description"],
Expand Down
4 changes: 4 additions & 0 deletions dojo/tools/harbor_vulnerability/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ def get_findings(self, filename, test):
fix_version = item.get("fix_version")
links = item.get("links")
cwe_ids = item.get("cwe_ids")
fix_available = True
if item.get("fix_version") == "":
fix_available = False

title = f"{item_id} - {package_name} ({package_version})"
severity = transpose_severity(severity)
Expand Down Expand Up @@ -82,6 +85,7 @@ def get_findings(self, filename, test):
component_name=package_name,
component_version=package_version,
cwe=cwe,
fix_available=fix_available,
)
if vulnerability_id:
find.unsaved_vulnerability_ids = [vulnerability_id]
Expand Down
1 change: 1 addition & 0 deletions unittests/tools/test_harbor_vulnerability_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def test_parse_file_with_one_vuln_has_one_findings(self):
self.assertEqual(finding.component_name, "package")
self.assertEqual(finding.component_version, "exploitable-version")
self.assertEqual(finding.references, "https://github.com/goharbor/harbor\n")
self.assertEqual(finding.fix_available, True)

# Sample with Multiple Test
def test_parse_file_with_multiple_vuln_has_multiple_findings(self):
Expand Down