Make Microsoft directory sync group filter case-insensitive#2658
Open
danielheimburg wants to merge 1 commit intoDefGuard:mainfrom
Open
Make Microsoft directory sync group filter case-insensitive#2658danielheimburg wants to merge 1 commit intoDefGuard:mainfrom
danielheimburg wants to merge 1 commit intoDefGuard:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developersvsDevelopersRoot cause
Microsoft per-user group sync fetches a user's groups from the
memberOfendpoint and then applies the configureddirectory_sync_group_matchfilter locally.That local filter used
Vec::contains(display_name), which is case-sensitive. In practice this meant a configured filter likedeveloperswould not match a directory group namedDevelopers, so the filtered set became empty and later sync logic removed the user's existing local groups.Code evidence
crates/defguard_core/src/enterprise/directory_sync/microsoft.rs: per-user group sync filtered with exactcontainscrates/defguard_core/src/enterprise/directory_sync/mod.rs: later sync removes groups not present in the filtered directory setTesting
protocbinary required by another crate, so the patch is code-reviewed but not fully executed here