feat(#4520): AGNTCY DIR directory client — agents-kt-dir module#224
Merged
Conversation
The directory pillar of the AGNTCY epic (#4517), beside OASF export/import (#4518/#4519)
and Identity-verify (#4521). With this, the epic's core is complete.
- DirClient over generated grpc-kotlin StoreService coroutine stubs: push/pushAll (OASF
record JSON -> CID), pull (CID -> JSON), lookup (metadata), delete. connect()/use{}.
- Record body is google.protobuf.Struct (JSON is the contract, no OASF protos); converted
with protobuf's canonical JsonFormat (whole numbers stay integral, e.g. {"id":1003}).
- Protos vendored as a TRIMMED, wire-compatible subset (same package/service/RPC/field
numbers/types; buf.validate options + unused referrer RPCs dropped) — avoids the
buf/validate proto closure while staying on-the-wire identical to a real DIR server.
- Auth: plaintext (dev) / TLS / OIDC bearer built in; SPIFFE/mTLS via caller-supplied
ManagedChannel (fromChannel).
- New feature module agents-kt-dir (package agents_engine.agntcy.dir) so the grpc/protobuf/
netty graph stays out of core. protoc + grpc + grpckt codegen via the protobuf gradle
plugin (verified on Gradle 9.5 / Kotlin 2.4). Platform-specific protoc/protoc-gen tool
binaries are trusted by group in verification-metadata (build tools, per-OS classifiers);
runtime jars are fully checksummed.
- 4 hermetic tests (in-process gRPC fake StoreService round trip). README + CHANGELOG +
PRD §12.6 + internals adjunct updated. RoutingService/SearchService + OCI referrers remain.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
17d8904 to
559b812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGNTCY DIR directory client — the last core subtask of epic #4517.
DirClientpublishes/discovers OASF records in the AGNTCY DIR content-addressed directory over generated grpc-kotlinStoreServicestubs.What landed
DirClient—push/pushAll(OASF JSON → CID),pull(CID → JSON),lookup(metadata),delete;AutoCloseable.google.protobuf.Struct(JSON is the contract, no OASF protos) via protobuf's canonicalJsonFormat— whole numbers stay integral ({"id":1003}, tested).buf.validatefield options (compile-time only) and unused referrer RPCs dropped, so we avoid the buf/validate proto closure while staying on-the-wire identical.ManagedChannel(fromChannel).agents-kt-dir(agents_engine.agntcy.dir) so the grpc/protobuf/netty graph stays out of core (the rag/identity pattern). Codegen via the protobuf Gradle plugin — verified working on Gradle 9.5 / Kotlin 2.4.Dependency verification
Platform-specific protoc / protoc-gen tool binaries are
trusted by group inverification-metadata.xml(build tools, per-OS classifiers — avoids needing a separate checksum per CI platform); the runtime grpc/protobuf/guava jars are fully checksummed (+328 entries, additive). whisper-jni lockfile drift excluded.Gates
4 hermetic tests (in-process gRPC fake
StoreServiceround trip — no daemon). Full./gradlew buildgreen (dir module + detekt + DocsConsistency + dependency verification). README + CHANGELOG + PRD §12.6 + internals adjunct updated.RoutingService/SearchService(network discovery) + OCI referrers are documented follow-ups; the content-addressable store client is the foundation. Closes #4520.🤖 Generated with Claude Code