-
Notifications
You must be signed in to change notification settings - Fork 0
feat(api)!: update entity output for having relations grouped #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brandPittCode
wants to merge
28
commits into
main
Choose a base branch
from
feat/update-entity-output-for-having-relations-grouped
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
bde7650
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode 5de8436
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode c7efad0
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode 6be5966
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode a104d92
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode de07bd3
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode a14ee99
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode 61ee074
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode 3cfe929
feat(core): update Entity Dto contract, mapper and controllers tests
brandPittCode 2632230
feat(core): update Entity output contract.
brandPittCode 646e269
feat(core): update Entity output contract.
brandPittCode d4dad57
feat(core): update Entity output contract.
brandPittCode 87ad843
feat(core): update Entity output contract
brandPittCode 7bdbefc
feat(core): update Entity output contract
brandPittCode 99a8a26
feat(core): update Entity output contract
brandPittCode 9dde05e
feat(core): update Entity output contract
brandPittCode 179d70b
feat(core): update Entity output contract
brandPittCode be64d9d
fet(core): update entity get endpoint tu use graph service
brandPittCode f52aae3
Merge branch 'main' into feat/update-entity-output-for-having-relatio…
brandPittCode 3388155
fet(core): update entity get endpoint tu use graph service
brandPittCode 0e4607b
fet(core): update entity get endpoint tu use graph service
brandPittCode f7dcfc8
Merge branch 'feat/add-relation-depth-to-get-entity-endpoint' into fe…
brandPittCode 04310e2
fet(core): update entity get endpoint tu use graph service
brandPittCode c4353e5
Merge branch 'main' into feat/update-entity-output-for-having-relatio…
brandPittCode 1c7def8
fet(core): update entity get endpoint tu use graph service
brandPittCode 74496d5
Merge branch 'feat/update-entity-output-for-having-relations-grouped'…
brandPittCode 3d5db3e
fet(core): update entity get endpoint tu use graph service
brandPittCode 06c4c3f
fet(core): update entity get endpoint tu use graph service
brandPittCode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/main/java/com/decathlon/idp_core/domain/model/entity_graph/FlowDirection.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| package com.decathlon.idp_core.domain.model.entity_graph; | ||
|
|
||
| /// Internal flow direction states used during graph traversal. | ||
| /// | ||
| /// Maps to relationship directions (outbound vs inbound) during BFS propagation. | ||
| /// This enum is used internally by [EntityGraphHelper] to track traversal flow | ||
| /// and should not be exposed in public APIs. | ||
| public enum FlowDirection { | ||
| /// Follow outbound relationships only (downstream dependencies) | ||
| OUTBOUND, | ||
| /// Follow inbound relationships only (upstream dependents) | ||
| INBOUND, | ||
| /// Follow both outbound and inbound relationships | ||
| ANY | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering sourceTemplateIdentifier is never used by the domain, isn't more an infra concern ? And should only be for dto and api responses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually at the end RelationAsTargetSummary object is the metadata for an entity. (identifier, name, template identifier) so it is stil a domain concern. I'l will check for maybe change the name. Or manage this in another way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still used by the mapper for the search. I propose to treat the mapper update for the search in another pr.