-
Notifications
You must be signed in to change notification settings - Fork 0
feat(core): DELETE entity endpoint #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RVANDO12
wants to merge
13
commits into
main
Choose a base branch
from
feat/entity/delete
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fb5ddbb
feat(core): add delete endpoint
RVANDO12 db61362
feat(core): little format issue
RVANDO12 504e046
feat(core): rebase with format
RVANDO12 d0cb5aa
feat(core): little refacto
RVANDO12 348d51a
feat(core): copilot reviewn - add DC and tu
RVANDO12 8f99ff6
feat(core): copilot reviewn - add DC and tu
RVANDO12 1d526fd
feat(core): unsued import and sonar qube issue
RVANDO12 bdbcd3e
feat(core): fix review - add nominal case
RVANDO12 ad2eb94
Merge branch 'main' into feat/entity/delete
RVANDO12 3c13980
feat(core): fix review - add nominal case
RVANDO12 ad3d11d
feat(core): fix review - eve
RVANDO12 21788fc
feat(core): fix review 2 - eve
RVANDO12 186a349
feat(core): fix review 2 - eve
RVANDO12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...n/java/com/decathlon/idp_core/domain/exception/entity/EntityDeletionBlockedException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package com.decathlon.idp_core.domain.exception.entity; | ||
|
|
||
| import static com.decathlon.idp_core.domain.constant.ValidationMessages.ENTITY_DELETION_BLOCKED; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /// Domain exception for blocked Entity deletion due to required relations. | ||
| /// | ||
| /// **Business purpose:** Represents the business rule violation when attempting | ||
| /// to delete an Entity that is still referenced by required relations in other entities. | ||
| /// This enforces the business invariant that required relations must be satisfied before | ||
| /// entity deletion is allowed. | ||
| /// | ||
| /// **Why this exception exists:** | ||
| /// - Enforces referential integrity and required relation constraints | ||
| /// - Prevents dangling required references that would leave entities in invalid states | ||
| /// - Provides detailed context about which entities/relations block the deletion | ||
| /// - Guides users on how to resolve the blocking constraint (update template or remove required flag) | ||
| public class EntityDeletionBlockedException extends RuntimeException { | ||
|
|
||
| /// Constructs a new exception with entity and blocking relation details. | ||
| /// | ||
| /// **Why this exists:** Provides comprehensive error message that includes: | ||
| /// - The entity being deleted (identifier and template) | ||
| /// - The list of entities that have required relations to it | ||
| /// - Actionable guidance on how to resolve the issue | ||
| /// | ||
| /// @param templateIdentifier the template identifier of the entity being | ||
| /// deleted | ||
| /// @param entityIdentifier the identifier of the entity being deleted | ||
| /// @param blockingEntities list of entity identifiers that have required | ||
| /// relations to the deleted entity | ||
| public EntityDeletionBlockedException(String templateIdentifier, String entityIdentifier, | ||
| List<String> blockingEntities) { | ||
| super(String.format(ENTITY_DELETION_BLOCKED, entityIdentifier, templateIdentifier, | ||
| String.join(", ", blockingEntities))); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.