[codex] fix euid_details hidden-section submits

[iamh2o]

Summary

• fix /save_json_addl_key so hidden-section submits on euid_details accept empty JSON payloads and preserve intended HTTP errors
• initialize obj.json_addl when absent before writing into properties or controlled_properties
• add GUI endpoint regressions for empty payload saves, controlled-properties saves, and missing-object 404 behavior

Root Cause

The hidden-section editors on /euid_details post through /save_json_addl_key. That route treated empty {} payloads as missing because it used truthiness checks, and it converted intended HTTPException responses into generic 500s.

Impact

Edit Properties and Edit Template Form submits now succeed for valid payloads and return honest errors when the target object is missing.

Validation

• source ./activate xxyyzz && python -m pytest --no-cov tests/test_gui_endpoints.py -k save_json_addl_key
• source ./activate xxyyzz && python -m ruff check tests/test_gui_endpoints.py

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ad25d18a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Avoid clobbering non-null json_addl payloads

The new guard in save_json_addl_key resets obj.json_addl to {} for any non-dict value, which means a legacy or string-encoded JSON payload will be silently replaced and then committed when users submit hidden-section edits. Because other code paths explicitly handle string-backed json_addl (for example _container_event_payload in api/v1/containers.py), this can cause real metadata loss on existing records instead of just initializing missing data. Initialize only when json_addl is None (or parse known legacy formats) to avoid destructive writes.

Useful? React with 👍 / 👎.