Use sort handle for signups on trip admin tab to make it scrollable on mobile#115
Open
collinmay wants to merge 1 commit intoDavidCain:masterfrom
Open
Use sort handle for signups on trip admin tab to make it scrollable on mobile#115collinmay wants to merge 1 commit intoDavidCain:masterfrom
collinmay wants to merge 1 commit intoDavidCain:masterfrom
Conversation
On mobile, the active area for starting drag-and-drop for signups on the admin spans almost the entire width of the screen, making it very difficult to scroll. By reducing the active area for starting a drag-and-drop operation to a smaller icon, it makes it much easier to scroll the page on mobile, while reducing the chance of accidentally reordering signups.
7fad384 to
1285988
Compare
Owner
|
I like this idea. Let me try it out and I'll likely merge it. Thanks for the work here. I was really hoping I'd have completely replaced this flow by now, but alas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-addresses #105.
On mobile, the active area for starting drag-and-drop for signups on the admin spans almost the entire width of the screen, making it very difficult to scroll. By reducing the active area for starting a drag-and-drop operation to a smaller icon, it makes it much easier to scroll the page on mobile, while reducing the chance of accidentally reordering signups.
Here's a recording of what it looks like to use the page in firefox dev tools simulating a mobile device. The cursor icon bugginess is an artifact of simulating touch inputs with a mouse.
On my actual phone, the scrolling experience is much more comfortable and the active area for beginning a drag is big enough to hit when I do mean to hit it.
On desktop, the cursor only switches to the grab icon when you are hovering over the drag handle.
I've left the other usage of ui-sortable in the lottery ranking selection alone. There are some minor CSS changes, but the cursor still behaves properly there.