Open
Conversation
sscdotopen
reviewed
Jul 12, 2020
Collaborator
sscdotopen
left a comment
sscdotopen
left a comment
There was a problem hiding this comment.
This looks good in general, but I would like to discuss it in our next meeting before we merge it.
fp/utils.py
Outdated
| @@ -0,0 +1,43 @@ | |||
| import pandas as pd | |||
|
|
|||
| def filter_optimal_results_skyline_order(_df, _order_list): | |||
Collaborator
There was a problem hiding this comment.
why is this code in this PR? This belongs to the skyline PR, right?
Member
Author
There was a problem hiding this comment.
Fixed by deleting it. This file should be deleted for the refactored code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add decomposed constructors for each step.