Async query service client#2090
Merged
shangyian merged 11 commits intoMay 8, 2026
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
force-pushed
the
async-query-service-client
branch
from
7825165 to
ae05bd3
Compare
…astAPI endpoints don't block the event loop
shangyian
force-pushed
the
async-query-service-client
branch
from
b2eba01 to
d52b2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the query service client's methods from blocking
requests.Sessioncalls tohttpx.AsyncClient. This way, DJ server's API endpoints that rely on the query service (e.g.,/data/) won't block the event loop on warehouse-side query work.These FastAPI routes are
async def, butrequests.postis sync, so query service calls likesubmit_query(and others) will hold the worker's event loop for the duration of the warehouse call. Other requests on the same worker can't make progress during that window. Swapping tohttpx.AsyncClientlets the loop service other requests while the warehouse call is in flight.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan