Draft
Conversation
Add GQL support for workspace queries Add UI support for workspace Refactor MyWorkspacePage with DashboardCard component Refactor MyWorkspacePage with custom data hooks Create reusable hooks for workspace data fetching: - useCurrentUser() - fetch current user - useWorkspaceOwnedNodes() - fetch owned nodes - useWorkspaceRecentlyEdited() - fetch recently edited nodes - useWorkspaceWatchedNodes() - fetch watched nodes - useWorkspaceCollections() - fetch collections - useWorkspaceNotifications() - fetch notifications with enrichment - useWorkspaceMaterializations() - fetch materialized nodes - useWorkspaceNeedsAttention() - fetch all actionable items - usePersonalNamespace() - check if personal namespace exists Refactor MyWorkspacePage to use hooks: - Replaced ~170 lines of manual state + useEffect with ~13 lines of hooks - Much cleaner, more maintainable code - Consistent error handling across all data fetching - Hooks are reusable in other components Also fixed DashboardCard bug: - Properly handle false/null/undefined children from conditional rendering - Fixed MaterializationsSection not showing content - Added safety check for nodes array to prevent crashes Impact: - Main component reduced from ~230 lines to ~70 lines - Data fetching logic now in dedicated hooks file - Easier to test and maintain - Consistent patterns across the app Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Create reusable Node display components Created NodeComponents.jsx with reusable node display components: - NodeBadge: Flexible badge with size variants (small/medium/large) - NodeLink: Reusable node link with ellipsis support - NodeDisplay: Combined link + badge display - NodeChip: Compact chip for NeedsAttentionSection Refactored MyWorkspacePage to use new components: - NotificationsSection: Use NodeBadge - NeedsAttentionSection: Use NodeChip (saved ~20 lines) - MaterializationsSection: Use NodeDisplay (saved ~11 lines) - NodeList: Use NodeDisplay with ellipsis (saved ~18 lines) Impact: - Removed ~80 lines of repetitive node display code - Consistent node display patterns across all sections - Easy to modify node display styling in one place - Components are reusable across the entire app Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan