Fix required dimensions component to read/write formik state properly#1783
Open
shangyian wants to merge 2 commits intoDataJunction:mainfrom
Open
Fix required dimensions component to read/write formik state properly#1783shangyian wants to merge 2 commits intoDataJunction:mainfrom
shangyian wants to merge 2 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
01deee1 to
1f34d7a
Compare
1f34d7a to
a9b043d
Compare
a9b043d to
2297957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where required dimensions get removed when editing a metric node from the UI. The issue comes from an uncontrolled formik field state. The setup before only set the initial display value, but didn't sync state with Formik unless the user interacted with the component. That meant that the form could submit with undefined if the field was never touched.
With this change, it always reads from
field.value(aka formik's state), so it's synced with formik at all times and the form will submit the current value.This fixes the bug for this flow:
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan