Draft
Conversation
kayvank
force-pushed
the
170/implement-Fisher-Yates-algorithm
branch
from
402f667 to
7eaf4e7
Compare
Contributor
|
Thanks for submitting a PR! I'll have a good look at it later but if you're open to it, you could look at a one-time test for randomness here: https://cnut1648.github.io/files/posts/Test_for_rand.pdf Basically, take the indices that are output by shuffleVec and take a look at the distribution. But that's might be overkill. |
mchav
requested changes
Mar 1, 2026
| where | ||
| shuffleVec :: (RandomGen g) => g -> VU.Vector Int -> VU.Vector Int | ||
| shuffleVec g v = runST $ do | ||
| vm <- VU.thaw v |
Member
There was a problem hiding this comment.
Instead of declaring the vector from list just to thaw it we can just create a new one in the shuffle vec function.
kayvank
force-pushed
the
170/implement-Fisher-Yates-algorithm
branch
from
fc6f38a to
cc83918
Compare
Issue 170, implement PR comments and clean up build warnings
kayvank
force-pushed
the
170/implement-Fisher-Yates-algorithm
branch
from
cc83918 to
3e69bd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.